Subject: Re: [PATCH v7 4/4] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes

From: Simon Horman <[email-masked]>
Date: Mon, 17 Jun 2024 16:17:13 +0100

On Mon, Jun 17, 2024 at 01:38:41PM +0200, Kamil Horák - 2N wrote:
> Implement single-pair BroadR-Reach modes on bcm5481x PHY by Broadcom.
> Create set of functions alternative to IEEE 802.3 to handle configuration
> of these modes on compatible Broadcom PHYs.
> 
> Signed-off-by: Kamil Horák - 2N <[email-masked]>

...

> +/**
> + * lre_update_link - update link status in @phydev
> + * @phydev: target phy_device struct
> + *
> + * Description: Update the value in phydev->link to reflect the
> + *   current link value.  In order to do this, we need to read
> + *   the status register twice, keeping the second value.
> + *   This is a genphy_update_link modified to work on LRE registers
> + *   of BroadR-Reach PHY
> + */

Hi Kamil,

A minor nit from my side:

Please consider adding a "Returns:" section to this kernel doc.
Doing so as a follow-up would be fine IMHO.

Flagged by kernel-doc -none -Wall

> +static int lre_update_link(struct phy_device *phydev)

...