Subject: Re: [PATCH v5 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice

From: Jakub Kicinski <[email-masked]>
Date: Tue, 18 Jun 2024 16:49:39 -0700

On Tue, 18 Jun 2024 23:44:22 +0100 [email-masked] wrote:
> +		xa_erase(&dev->ethtool->rss_ctx, context);
> +		if (dev->ethtool_ops->cap_rss_ctx_supported)
> +			dev->ethtool_ops->set_rxfh(dev, &rxfh, NULL);
> +		else /* can't happen */
> +			pr_warn_once("No callback to remove RSS context from %s\n",
> +				     netdev_name(dev));

nit: I'd be tempted to call dev->ethtool_ops->set_rxfh()
     unconditionally. Is there a legit scenario where context 
     may exist but there's no set_rxfh callback?

If you prefer to keep the check - netdev_warn_once() ?