From: Jakub Kicinski <kuba@kernel•org>
To: Denis Arefev <arefev@swemel•ru>
Cc: jiri@resnulli•us, edumazet@google•com, eperezma@redhat•com,
jasowang@redhat•com, linux-kernel@vger•kernel.org,
lvc-project@linuxtesting•org, mst@redhat•com,
netdev@vger•kernel.org, virtualization@lists•linux.dev,
xuanzhuo@linux•alibaba.com
Subject: Re: [PATCH v2] net: missing check virtio
Date: Tue, 18 Jun 2024 17:45:00 -0700 [thread overview]
Message-ID: <20240618174500.49a3045b@kernel.org> (raw)
In-Reply-To: <20240614101826.30518-1-arefev@swemel.ru>
On Fri, 14 Jun 2024 13:18:26 +0300 Denis Arefev wrote:
> Yeah, I was thinking of adding Fixes:
>
> But this code is new, it complements what is done.
> 1. check (!(ret && (hdr->gso_size > needed) &&
> ((remainder > needed) || (remainder == 0))))
> complements comit 0f6925b3e8da0
>
> 2. The setting of the SKBFL_SHARED_FRAG flag can be associated with this comit cef401de7be8c.
> In the skb_checksum_help function, a check for skb_has_shared_frag has been added.
> If the flag is not set, the skb buffer will remain non-linear, which is not good.
The Fixes tag indicates how far back the bug would trigger.
next prev parent reply other threads:[~2024-06-19 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 9:54 [PATCH v2] net: missing check virtio Denis Arefev
2024-06-13 14:49 ` Jiri Pirko
2024-06-14 10:18 ` Denis Arefev
2024-06-19 0:45 ` Jakub Kicinski [this message]
2024-06-19 7:51 ` Michael S. Tsirkin
2024-07-03 16:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618174500.49a3045b@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=arefev@swemel$(echo .)ru \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lvc-project@linuxtesting$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox