Subject: Re: [PATCH net-next v11 5/7] net: tn40xx: add basic Rx handling

From: Jakub Kicinski <[email-masked]>
Date: Tue, 18 Jun 2024 18:52:10 -0700

On Tue, 18 Jun 2024 14:16:06 +0900 FUJITA Tomonori wrote:
> +		skb = napi_build_skb(page_address(dm->page), PAGE_SIZE);
> +		if (!skb) {
> +			netdev_err(priv->ndev, "napi_build_skb() failed\n");

memory pressure happens a lot in real world scenarios,
allocations will fail, and you don't want to spam the logs
in such cases.

In general prints on the datapath can easily turn into a DoS vector.
You're better off using appropriate statistics (here struct
netdev_queue_stats_rx :: alloc_fail)