Subject: Re: [PATCH v2 3/3] mctp pcc: Implement MCTP over PCC Transport

From: Jakub Kicinski <[email-masked]>
Date: Wed, 19 Jun 2024 16:26:42 -0700

On Wed, 19 Jun 2024 16:05:52 -0400 [email-masked] wrote:
> From: Adam Young <[email-masked]>
> 
> Implementation of DMTF DSP:0292
> Management Control Transport Protocol(MCTP) over
> Platform Communication Channel(PCC) network driver.
> 
> MCTP devices are specified by entries in DSDT/SDST and
> reference channels specified in the PCCT.
> 
> Communication with other devices use the PCC based
> doorbell mechanism.

This patch breaks allmodconfig build:

drivers/net/mctp/mctp-pcc.c:116:6: warning: unused variable 'rc' [-Wunused-variable]
  116 |         int rc;
      |             ^~
drivers/net/mctp/mctp-pcc.c:344:3: error: field designator 'owner' does not refer to any field in type 'struct acpi_driver'
  344 |         .owner = THIS_MODULE,
      |         ~^~~~~~~~~~~~~~~~~~~

In addition, please make sure you don't add new checkpatch warnings,
use:

  ./scripts/checkpatch.pl --strict --max-line-length=80 $patch

Please wait with the repost until next week, unless you get a review
from Jeremy before that. When reposting start a new thread, don't
repost in reply to previous posting. Instead add a lore link to the
previous version, like this:

https://lore.kernel.org/[email-masked]/

See also:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
-- 
pw-bot: cr