Subject: Re: [PATCH net] ionic: use dev_consume_skb_any outside of napi

From: Jakub Kicinski <[email-masked]>
Date: Wed, 19 Jun 2024 16:44:34 -0700

On Wed, 19 Jun 2024 14:20:22 -0700 Shannon Nelson wrote:
> I found that ionic_tx_clean() calls napi_consume_skb() which calls
> napi_skb_cache_put(), but before that last call is the note
>     /* Zero budget indicate non-NAPI context called us, like netpoll */
> and
>     DEBUG_NET_WARN_ON_ONCE(!in_softirq());
> 
> Those are pretty big hints that we're doing it wrong.  So, let's pass a 0
> when we know we're not in a napi context.

Just pass the NAPI budget in, and if not in NAPI pass 0.
A bit more plumbing thru, but a lot less thinking required during
review..
-- 
pw-bot: cr