Subject: Re: [PATCH net-next v3 05/10] net: openvswitch: add emit_sample action

From: Jakub Kicinski <[email-masked]>
Date: Wed, 19 Jun 2024 18:39:43 -0700

On Wed, 19 Jun 2024 23:00:06 +0200 Adrian Moreno wrote:
> +	OVS_EMIT_SAMPLE_ATTR_UNPSEC,

Are you using this one? Looking closely I presume not, since it's
misspelled ;) You can assign = 1 to GROUP, no need to name the value
for 0.

> +	OVS_EMIT_SAMPLE_ATTR_GROUP,	/* u32 number. */
> +	OVS_EMIT_SAMPLE_ATTR_COOKIE,	/* Optional, user specified cookie. */
> +	__OVS_EMIT_SAMPLE_ATTR_MAX

kdoc is complaining that __OVS_EMIT_SAMPLE_ATTR_MAX is not documented.
You can add:

	/* private: */

before, take a look at include/uapi/linux/netdev.h for example.
-- 
pw-bot: cr