From: Simon Horman <horms@kernel•org>
To: Danielle Ratson <danieller@nvidia•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, corbet@lwn•net,
linux@armlinux•org.uk, sdf@google•com, kory.maincent@bootlin•com,
maxime.chevallier@bootlin•com, vladimir.oltean@nxp•com,
przemyslaw.kitszel@intel•com, ahmed.zaki@intel•com,
richardcochran@gmail•com, shayagr@amazon•com,
paul.greenwalt@intel•com, jiri@resnulli•us,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
mlxsw@nvidia•com, idosch@nvidia•com, petrm@nvidia•com
Subject: Re: [PATCH net-next v6 4/9] ethtool: Add flashing transceiver modules' firmware notifications ability
Date: Thu, 20 Jun 2024 20:30:23 +0100 [thread overview]
Message-ID: <20240620193023.GS959333@kernel.org> (raw)
In-Reply-To: <20240619121727.3643161-5-danieller@nvidia.com>
On Wed, Jun 19, 2024 at 03:17:22PM +0300, Danielle Ratson wrote:
> Add progress notifications ability to user space while flashing modules'
> firmware by implementing the interface between the user space and the
> kernel.
>
> Signed-off-by: Danielle Ratson <danieller@nvidia•com>
> Reviewed-by: Petr Machata <petrm@nvidia•com>
...
> diff --git a/net/ethtool/module.c b/net/ethtool/module.c
...
> @@ -158,3 +159,119 @@ const struct ethnl_request_ops ethnl_module_request_ops = {
> .set = ethnl_set_module,
> .set_ntf_cmd = ETHTOOL_MSG_MODULE_NTF,
> };
> +
> +/* MODULE_FW_FLASH_NTF */
> +
> +static int
> +ethnl_module_fw_flash_ntf_put_err(struct sk_buff *skb, char *err_msg,
> + char *sub_err_msg)
> +{
> + int err_msg_len, sub_err_msg_len, total_len;
> + struct nlattr *attr;
> +
> + if (!err_msg)
> + return 0;
> +
> + err_msg_len = strlen(err_msg);
> + total_len = err_msg_len + 2; /* For period and NUL. */
> +
> + if (sub_err_msg) {
> + sub_err_msg_len = strlen(sub_err_msg);
> + total_len += sub_err_msg_len + 2; /* For ", ". */
> + }
> +
> + attr = nla_reserve(skb, ETHTOOL_A_MODULE_FW_FLASH_STATUS_MSG,
> + total_len);
> + if (!attr)
> + return PTR_ERR(attr);
Hi Danielle,
attr is NULL here, so I think this will return 0.
Perhaps it should return an negative error value,
say -ENOMEM, instead?
Flagged by Smatch
> +
> + if (sub_err_msg)
> + sprintf(nla_data(attr), "%s, %s.", err_msg, sub_err_msg);
> + else
> + sprintf(nla_data(attr), "%s.", err_msg);
> +
> + return 0;
> +}
...
next prev parent reply other threads:[~2024-06-20 19:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 12:17 [PATCH net-next v6 0/9] Add ability to flash modules' firmware Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 1/9] ethtool: Add ethtool operation to write to a transceiver module EEPROM Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 2/9] mlxsw: Implement " Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 3/9] ethtool: Add an interface for flashing transceiver modules' firmware Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 4/9] ethtool: Add flashing transceiver modules' firmware notifications ability Danielle Ratson
2024-06-20 19:30 ` Simon Horman [this message]
2024-06-19 12:17 ` [PATCH net-next v6 5/9] ethtool: Veto some operations during firmware flashing process Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 6/9] net: sfp: Add more extended compliance codes Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 7/9] ethtool: cmis_cdb: Add a layer for supporting CDB commands Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 8/9] ethtool: cmis_fw_update: add a layer for supporting firmware update using CDB Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 9/9] ethtool: Add ability to flash transceiver modules' firmware Danielle Ratson
2024-06-20 1:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620193023.GS959333@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paul.greenwalt@intel$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox