Subject: Re: [PATCH V2] hippi: fix possible buffer overflow caused by bad DMA value in rr_start_xmit()

From: Jakub Kicinski <[email-masked]>
Date: Fri, 21 Jun 2024 08:34:45 -0700

On Fri, 21 Jun 2024 05:11:41 +0000 Sunil Kovvuri Goutham wrote:
> >+	if (index >= TX_RING_ENTRIES) {
> >+		netdev_err(dev, "invalid index value %02x\n", index);  
> 
> Much better would be to use netif_msg_tx_err which can be
> enabled/disabled instead of dumping on console, which would be
> annoying if there are many errors.

Doesn't it require ethtool to be changed tho? This driver doesn't have
any ethtool ops AFAICT. I'd go for netdev_err_once().

But more importantly, I think you should stop the queue before
returning BUSY.