Subject: Re: [PATCH net-next 4/4] selftests: drv-net: rss_ctx: add tests for RSS configuration and contexts

From: Jakub Kicinski <[email-masked]>
Date: Mon, 24 Jun 2024 09:02:06 -0700

On Mon, 24 Jun 2024 07:50:35 -0700 Jakub Kicinski wrote:
> > > +    key_len = len(data['rss-hash-key'])
> > > +
> > > +    # Set the key
> > > +    key = _rss_key_rand(key_len)
> > > +    ethtool(f"-X {cfg.ifname} hkey " + _rss_key_str(key))    
> > 
> > Probably too paranoid, but in case failure is only for some randomized
> > input, is the key logged on error?  
> 
> Will add!

I take that back, if ethtool() -> tool() -> cmd() fails we'll throw 
and exception which already includes the command as well as stdout
and stderr. So we'll see in the logs what the key was.