Subject: Re: [PATCH v1 net 00/11] af_unix: Fix bunch of MSG_OOB bugs and add new tests.

From: Jakub Kicinski <[email-masked]>
Date: Tue, 25 Jun 2024 17:43:18 -0700

On Mon, 24 Jun 2024 18:36:34 -0700 Kuniyuki Iwashima wrote:
> This series rewrites the selftest for AF_UNIX MSG_OOB and fixes
> bunch of bugs that AF_UNIX behaves differently compared to TCP.

I like pairing the fix with the selftest, but at the same time
"let's rewrite the selftest first" gives me pause. We have 40 LoC
of actual changes here and 1000 LoC of test churn.

I guess we'll find out on Thursday if we went too far :)

>  net/unix/af_unix.c                            |  37 +-
>  tools/testing/selftests/net/.gitignore        |   1 -
>  tools/testing/selftests/net/af_unix/Makefile  |   2 +-
>  tools/testing/selftests/net/af_unix/msg_oob.c | 734 ++++++++++++++++++
>  .../selftests/net/af_unix/test_unix_oob.c     | 436 -----------
>  5 files changed, 766 insertions(+), 444 deletions(-)
>  create mode 100644 tools/testing/selftests/net/af_unix/msg_oob.c
>  delete mode 100644 tools/testing/selftests/net/af_unix/test_unix_oob.c