Subject: Re: [PATCH iwl-next 5/7] ice: Disable shared pin on E810 on setfunc

From: Simon Horman <[email-masked]>
Date: Mon, 1 Jul 2024 14:27:21 +0100

On Thu, Jun 27, 2024 at 05:09:29PM +0200, Karol Kolacinski wrote:
> When setting a new supported function for a pin on E810, disable other
> enabled pin that shares the same GPIO.
> 
> Reviewed-by: Arkadiusz Kubalewski <[email-masked]>
> Signed-off-by: Karol Kolacinski <[email-masked]>
> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.c | 65 ++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c

...

> @@ -1885,6 +1942,14 @@ static int ice_verify_pin(struct ptp_clock_info *info, unsigned int pin,
>  		return -EOPNOTSUPP;
>  	}
>  
> +	/* On adapters with SMA_CTRL disable other pins that share same GPIO */
> +	if (ice_is_feature_supported(pf, ICE_F_SMA_CTRL)) {
> +		ice_ptp_disable_shared_pin(pf, pin, func);
> +		pf->ptp.pin_desc[pin].func = func;
> +		pf->ptp.pin_desc[pin].chan = chan;
> +		return ice_ptp_set_sma_cfg_e810t(pf);

This appears to be resolved in the following patch by calling
ice_ptp_set_sma_cfg_() instead, but this fails to build because
ice_ptp_set_sma_cfg_e810t() does not exits.

> +	}
> +
>  	return 0;
>  }
> -- 
> 2.45.2