From: Jakub Kicinski <kuba@kernel•org>
To: Liu Jing <liujing@cmss•chinamobile.com>
Cc: davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
shuah@kernel•org, netdev@vger•kernel.org,
linux-kselftest@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params)
Date: Mon, 1 Jul 2024 20:03:07 -0700 [thread overview]
Message-ID: <20240701200307.6fbcbacc@kernel.org> (raw)
In-Reply-To: <20240701113251.6630-1-liujing@cmss.chinamobile.com>
On Mon, 1 Jul 2024 19:32:51 +0800 Liu Jing wrote:
> In the TEST_F(epoll_busy_poll, test_get_params), the initialized value of 'ret' is unused,
> because it will be assigned by the ioctl.thus remove it.
I don't think this is worth the noise, please don't send such changes
to networking.
prev parent reply other threads:[~2024-07-02 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 11:32 [PATCH] selftest: epoll_busy_poll: remove unnecessary assignment in TEST_F(epoll_busy_poll, test_get_params) Liu Jing
2024-07-02 3:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701200307.6fbcbacc@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=liujing@cmss$(echo .)chinamobile.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox