Subject: Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

From: Simon Horman <[email-masked]>
Date: Tue, 2 Jul 2024 08:17:39 +0100

On Sat, Jun 29, 2024 at 05:01:38PM +0200, Lorenzo Bianconi wrote:

...

> diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c

...

> +#define INT_IDX4_MASK						\
> +	(TX8_COHERENT_INT_MASK | TX9_COHERENT_INT_MASK |	\
> +	 TX10_COHERENT_INT_MASK | TX11_COHERENT_INT_MASK |	\
> +	 TX12_COHERENT_INT_MASK | TX13_COHERENT_INT_MASK |	\
> +	 TX14_COHERENT_INT_MASK | TX15_COHERENT_INT_MASK |	\
> +	 TX16_COHERENT_INT_MASK | TX17_COHERENT_INT_MASK |	\
> +	 TX18_COHERENT_INT_MASK | TX19_COHERENT_INT_MASK |	\
> +	 TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK |	\
> +	 TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK |	\

Hi Lorenzo,

One more thing that I forgot to note yesterday:
the two lines above appear to be duplicates of each other.

Flagged by Coccinelle.

> +	 TX22_COHERENT_INT_MASK | TX23_COHERENT_INT_MASK |	\
> +	 TX24_COHERENT_INT_MASK | TX25_COHERENT_INT_MASK |	\
> +	 TX26_COHERENT_INT_MASK | TX27_COHERENT_INT_MASK |	\
> +	 TX28_COHERENT_INT_MASK | TX29_COHERENT_INT_MASK |	\
> +	 TX30_COHERENT_INT_MASK | TX31_COHERENT_INT_MASK)

...