Subject: Re: [PATCH net-next v7 05/10] net: openvswitch: add psample action

From: Jakub Kicinski <[email-masked]>
Date: Tue, 2 Jul 2024 11:24:54 -0700

On Tue, 2 Jul 2024 20:16:51 +0200 Ilya Maximets wrote:
> On 7/2/24 20:06, Jakub Kicinski wrote:
> > On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote:  
> >> Or create a simple static function and mark all the arguments as unused,
> >> which kind of compliant to the coding style, but the least pretty.  
> > 
> > To be clear - kernel explicitly disables warnings about unused
> > arguments. Unused arguments are not a concern.  
> 
> OK.  Good to know.
> 
> Though I think, the '12) Macros, Enums and RTL' section of the
> coding style document needs some rephrasing in that case.

Do you mean something like:

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 7e768c65aa92..0516b7009688 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -828,7 +828,7 @@ Generally, inline functions are preferable to macros resembling functions.
 		} while (0)
 
 Function-like macros with unused parameters should be replaced by static
-inline functions to avoid the issue of unused variables:
+inline functions to avoid the issue of unused variables in the caller:
 
 .. code-block:: c
 
?