Subject: Re: [PATCH v4 3/3] mctp pcc: Implement MCTP over PCC Transport

From: Simon Horman <[email-masked]>
Date: Wed, 3 Jul 2024 20:53:38 +0100

On Tue, Jul 02, 2024 at 06:58:45PM -0400, [email-masked] wrote:
> From: Adam Young <[email-masked]>
> 
> Implementation of network driver for
> Management Control Transport Protocol(MCTP) over
> Platform Communication Channel(PCC)
> 
> DMTF DSP:0292
> 
> MCTP devices are specified by entries in DSDT/SDST and
> reference channels specified in the PCCT.
> 
> Communication with other devices use the PCC based
> doorbell mechanism.
> 
> Signed-off-by: Adam Young <[email-masked]>
> ---
>  drivers/net/mctp/Kconfig    |  13 ++
>  drivers/net/mctp/Makefile   |   1 +
>  drivers/net/mctp/mctp-pcc.c | 322 ++++++++++++++++++++++++++++++++++++

...

> diff --git a/drivers/net/mctp/mctp-pcc.c b/drivers/net/mctp/mctp-pcc.c

...

> +static struct acpi_driver mctp_pcc_driver = {
> +	.name = "mctp_pcc",
> +	.class = "Unknown",
> +	.ids = mctp_pcc_device_ids,
> +	.ops = {
> +		.add = mctp_pcc_driver_add,
> +		.remove = mctp_pcc_driver_remove,
> +	},
> +	.owner = THIS_MODULE,

Hi Adam,

Perhaps net-next isn't the appropriate tree to apply this patch.
But, due to [1] the owner field is not present in net-next and
thus this fails to build when applied there.

[1] cc85f9c05bba ("ACPI: drop redundant owner from acpi_driver")

> +};
> +
> +module_acpi_driver(mctp_pcc_driver);
> +
> +MODULE_DEVICE_TABLE(acpi, mctp_pcc_device_ids);
> +
> +MODULE_DESCRIPTION("MCTP PCC device");
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Adam Young <[email-masked]>");
> -- 
> 2.34.1
> 
>