Subject: Re: [net-next PATCH v3 08/15] eth: fbnic: Implement Tx queue alloc/start/stop/free

From: Simon Horman <[email-masked]>
Date: Wed, 3 Jul 2024 21:15:02 +0100

On Tue, Jul 02, 2024 at 08:00:11AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <[email-masked]>
> 
> Implement basic management operations for Tx queues.
> Allocate memory for submission and completion rings.
> Learn how to start the queues, stop them, and wait for HW
> to be idle.
> 
> We call HW rings "descriptor rings" (stored in ring->desc),
> and SW context rings "buffer rings" (stored in ring->*_buf union).
> 
> This is the first patch which actually touches CSRs so add CSR
> helpers.
> 
> No actual datapath / packet handling here, yet.
> 
> Signed-off-by: Alexander Duyck <[email-masked]>

...

> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c

...

> +void fbnic_fill(struct fbnic_net *fbn)

Hi Alexander,

Although it is done as part of a later patch in the series,
to avoid W=1 builds complaining, it would be best to add
a declaration of fbnic_fill to this patch.

> +{
> +	struct fbnic_napi_vector *nv;
> +
> +	list_for_each_entry(nv, &fbn->napis, napis) {
> +		int i;
> +
> +		/* Configure NAPI mapping for Tx */
> +		for (i = 0; i < nv->txt_count; i++) {
> +			struct fbnic_q_triad *qt = &nv->qt[i];
> +
> +			/* Nothing to do if Tx queue is disabled */
> +			if (qt->sub0.flags & FBNIC_RING_F_DISABLED)
> +				continue;
> +
> +			/* Associate Tx queue with NAPI */
> +			netif_queue_set_napi(nv->napi.dev, qt->sub0.q_idx,
> +					     NETDEV_QUEUE_TYPE_TX, &nv->napi);
> +		}

It is fixed in a subsequent patch of this series,
but a '}' should go here.

> +}

-- 
pw-bot: changes-requested