From: Simon Horman <horms@kernel•org>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, pavan.chebbi@broadcom•com,
andrew.gospodarek@broadcom•com
Subject: Re: [PATCH net] bnxt_en: Fix the resource check condition for RSS contexts
Date: Thu, 4 Jul 2024 10:20:06 +0100 [thread overview]
Message-ID: <20240704092006.GZ598357@kernel.org> (raw)
In-Reply-To: <20240703180112.78590-1-michael.chan@broadcom.com>
On Wed, Jul 03, 2024 at 11:01:12AM -0700, Michael Chan wrote:
> From: Pavan Chebbi <pavan.chebbi@broadcom•com>
>
> While creating a new RSS context, bnxt_rfs_capable() currently
> makes a strict check to see if the required VNICs are already
> available. If the current VNICs are not what is required,
> either too many or not enough, it will call the firmware to
> reserve the exact number required.
>
> There is a bug in the firmware when the driver tries to
> relinquish some reserved VNICs and RSS contexts. It will
> cause the default VNIC to lose its RSS configuration and
> cause receive packets to be placed incorrectly.
>
> Workaround this problem by skipping the resource reduction.
> The driver will not reduce the VNIC and RSS context reservations
> when a context is deleted. The resources will be available for
> use when new contexts are created later.
>
> Potentially, this workaround can cause us to run out of VNIC
> and RSS contexts if there are a lot of VF functions creating
> and deleting RSS contexts. In the future, we will conditionally
> disable this workaround when the firmware fix is available.
>
> Fixes: 438ba39b25fe ("bnxt_en: Improve RSS context reservation infrastructure")
> Reported-by: Jakub Kicinski <kuba@kernel•org>
> Link: https://lore.kernel.org/netdev/20240625010210.2002310-1-kuba@kernel.org/
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom•com>
> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom•com>
> Signed-off-by: Michael Chan <michael.chan@broadcom•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-07-04 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 18:01 [PATCH net] bnxt_en: Fix the resource check condition for RSS contexts Michael Chan
2024-07-04 9:20 ` Simon Horman [this message]
2024-07-04 14:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704092006.GZ598357@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox