From: Simon Horman <horms@kernel•org>
To: Florian Westphal <fw@strlen•de>
Cc: netdev@vger•kernel.org, xiyou.wangcong@gmail•com,
jiri@resnulli•us, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
jhs@mojatatu•com
Subject: Re: [PATCH net-next v2] act_ct: prepare for stolen verdict coming from conntrack and nat engine
Date: Fri, 5 Jul 2024 10:42:22 +0100 [thread overview]
Message-ID: <20240705094222.GC1095183@kernel.org> (raw)
In-Reply-To: <20240704112925.10975-1-fw@strlen.de>
On Thu, Jul 04, 2024 at 01:29:20PM +0200, Florian Westphal wrote:
> At this time, conntrack either returns NF_ACCEPT or NF_DROP.
> To improve debuging it would be nice to be able to replace NF_DROP verdict
nit: debugging
(I don't think there is a need to repost just because of this)
> with NF_DROP_REASON() helper,
>
> This helper releases the skb instantly (so drop_monitor can pinpoint
> exact location) and returns NF_STOLEN.
>
> Prepare call sites to deal with this before introducing such changes
> in conntrack and nat core.
>
> Signed-off-by: Florian Westphal <fw@strlen•de>
> ---
> No changes, v1 errounously targetted 'net' tree.
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-07-05 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 11:29 [PATCH net-next v2] act_ct: prepare for stolen verdict coming from conntrack and nat engine Florian Westphal
2024-07-05 9:42 ` Simon Horman [this message]
2024-07-08 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705094222.GC1095183@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox