public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen•de>
To: Jozsef Kadlecsik <kadlec@blackhole•kfki.hu>
Cc: Florian Westphal <fw@strlen•de>, yyxRoy <yyxroy22@gmail•com>,
	pablo@netfilter•org, gregkh@linuxfoundation•org,
	davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
	pabeni@redhat•com, netfilter-devel@vger•kernel.org,
	coreteam@netfilter•org, netdev@vger•kernel.org,
	linux-kernel@vger•kernel.org, yyxRoy <979093444@qq•com>
Subject: Re: [PATCH] netfilter: conntrack: tcp: do not lower timeout to CLOSE for in-window RSTs
Date: Sat, 6 Jul 2024 19:04:32 +0200	[thread overview]
Message-ID: <20240706170432.GA7766@breakpoint.cc> (raw)
In-Reply-To: <1173262c-a471-683f-9e00-abc8192c9ca8@blackhole.kfki.hu>

Jozsef Kadlecsik <kadlec@blackhole•kfki.hu> wrote:
> I fully agree with Florian: conntrack plays the role of a middle box and 
> cannot absolutely know the right seq/ack numbers of the client/server 
> sides. Add NAT on top of that and there are a couple of ways to attack a 
> given traffic. I don't see a way by which the checkings/parameters could 
> be tightened without blocking real traffic.

I forgot about TCP timestamps, which we do not track at the moment.

But then there is a slight caveat: if one side exits, RST won't
carry timestamp option, so even keeping track of timestamps will help
:-(

  reply	other threads:[~2024-07-06 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  4:00 [PATCH] netfilter: conntrack: tcp: do not lower timeout to CLOSE for in-window RSTs yyxRoy
2024-07-05  9:43 ` Florian Westphal
2024-07-06 16:16   ` Jozsef Kadlecsik
2024-07-06 17:04     ` Florian Westphal [this message]
2024-07-08  8:59       ` yyxRoy
2024-07-08 14:12         ` Florian Westphal
2024-07-10  9:45           ` yyxRoy
2024-07-10 13:49             ` Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240706170432.GA7766@breakpoint.cc \
    --to=fw@strlen$(echo .)de \
    --cc=979093444@qq$(echo .)com \
    --cc=coreteam@netfilter$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=kadlec@blackhole$(echo .)kfki.hu \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=pablo@netfilter$(echo .)org \
    --cc=yyxroy22@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox