Subject: Re: [PATCH net-next v2] bna: adjust 'name' buf size of bna_tcb and bna_ccb structures

From: Simon Horman <[email-masked]>
Date: Tue, 9 Jul 2024 13:00:07 +0100

On Mon, Jul 08, 2024 at 10:50:08AM +0000, Alexey Kodanev wrote:
> To have enough space to write all possible sprintf() args. Currently
> 'name' size is 16, but the first '%s' specifier may already need at
> least 16 characters, since 'bnad->netdev->name' is used there.
> 
> For '%d' specifiers, assume that they require:
>  * 1 char for 'tx_id + tx_info->tcb[i]->id' sum, BNAD_MAX_TXQ_PER_TX is 8
>  * 2 chars for 'rx_id + rx_info->rx_ctrl[i].ccb->id', BNAD_MAX_RXP_PER_RX
>    is 16
> 
> And replace sprintf with snprintf.
> 
> Detected using the static analysis tool - Svace.
> 
> Fixes: 8b230ed8ec96 ("bna: Brocade 10Gb Ethernet device driver")
> Signed-off-by: Alexey Kodanev <[email-masked]>
> ---
> 
> v2: * target at net-next
>     * line length fix

Thanks for the updates.

Reviewed-by: Simon Horman <[email-masked]>