From: Herve Codina <herve.codina@bootlin•com>
To: Lee Jones <lee@kernel•org>
Cc: Andy Shevchenko <andy.shevchenko@gmail•com>,
Simon Horman <horms@kernel•org>, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
UNGLinuxDriver@microchip•com,
Saravana Kannan <saravanak@google•com>,
Bjorn Helgaas <bhelgaas@google•com>,
Philipp Zabel <p.zabel@pengutronix•de>,
Lars Povlsen <lars.povlsen@microchip•com>,
Steen Hegelund <Steen.Hegelund@microchip•com>,
Daniel Machon <daniel.machon@microchip•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Horatiu Vultur <horatiu.vultur@microchip•com>,
Andrew Lunn <andrew@lunn•ch>,
linux-kernel@vger•kernel.org, devicetree@vger•kernel.org,
netdev@vger•kernel.org, linux-pci@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
Allan Nielsen <allan.nielsen@microchip•com>,
Luca Ceresoli <luca.ceresoli@bootlin•com>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Subject: Re: [PATCH v3 6/7] mfd: Add support for LAN966x PCI device
Date: Thu, 11 Jul 2024 18:44:38 +0200 [thread overview]
Message-ID: <20240711184438.65446cc3@bootlin.com> (raw)
In-Reply-To: <20240711152952.GL501857@google.com>
Hi Lee,
On Thu, 11 Jul 2024 16:29:52 +0100
Lee Jones <lee@kernel•org> wrote:
> On Thu, 27 Jun 2024, Herve Codina wrote:
>
> > Add a PCI driver that handles the LAN966x PCI device using a device-tree
> > overlay. This overlay is applied to the PCI device DT node and allows to
> > describe components that are present in the device.
> >
> > The memory from the device-tree is remapped to the BAR memory thanks to
> > "ranges" properties computed at runtime by the PCI core during the PCI
> > enumeration.
> >
> > The PCI device itself acts as an interrupt controller and is used as the
> > parent of the internal LAN966x interrupt controller to route the
> > interrupts to the assigned PCI INTx interrupt.
>
> Not entirely sure why this is in MFD.
This PCI driver purpose is to instanciate many other drivers using a DT
overlay. I think MFD is the right subsystem.
It acts as an interrupt controller because we need to have a bridge between the
device-tree interrupt world and the the PCI world.
This bridge is needed and specific to the driver in order to have resources
available from the device-tree world present in the applied overlay.
>
> Also I'm unsure of his current views, but Greg has voiced pretty big
> feelings about representing PCI drivers as Platform ones in the past.
PCI drivers as Plaform ones ?
I probably missed something. Can you give me more details ?
Best regards,
Hervé
next prev parent reply other threads:[~2024-07-11 16:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 9:11 [PATCH v3 0/7] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-06-27 9:11 ` [PATCH v3 1/7] mfd: syscon: Add reference counting and device managed support Herve Codina
2024-07-11 16:09 ` Markus Elfring
2024-07-11 16:25 ` Herve Codina
2024-07-11 17:09 ` Lee Jones
2024-06-27 9:11 ` [PATCH v3 2/7] reset: mchp: sparx5: Remove dependencies and allow building as a module Herve Codina
2024-07-23 7:21 ` Geert Uytterhoeven
2024-06-27 9:11 ` [PATCH v3 3/7] reset: mchp: sparx5: Release syscon when not use anymore Herve Codina
2024-06-27 9:11 ` [PATCH v3 4/7] reset: core: add get_device()/put_device on rcdev Herve Codina
2024-06-27 9:11 ` [PATCH v3 5/7] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
2024-06-27 9:11 ` [PATCH v3 6/7] mfd: Add support for LAN966x PCI device Herve Codina
2024-07-11 15:29 ` Lee Jones
2024-07-11 16:44 ` Herve Codina [this message]
2024-07-11 19:08 ` Greg Kroah-Hartman
2024-07-11 20:33 ` Rob Herring
2024-07-12 8:57 ` Greg Kroah-Hartman
2024-07-12 13:11 ` Herve Codina
2024-07-12 14:14 ` Arnd Bergmann
2024-07-15 12:12 ` Herve Codina
2024-07-16 14:44 ` Arnd Bergmann
2024-07-16 15:58 ` Herve Codina
2024-06-27 9:11 ` [PATCH v3 7/7] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711184438.65446cc3@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=allan.nielsen@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=daniel.machon@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lars.povlsen@microchip$(echo .)com \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=luca.ceresoli@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=saravanak@google$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox