Subject: Re: [PATCH net-next] net: virtio: fix virtnet_sq_free_stats initialization

From: Simon Horman <[email-masked]>
Date: Fri, 12 Jul 2024 19:20:21 +0100

On Fri, Jul 12, 2024 at 06:41:34AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jul 12, 2024 at 09:03:30AM +0100, Jean-Philippe Brucker wrote:
> > Commit c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits")
> > added two new fields to struct virtnet_sq_free_stats, but commit
> > 23c81a20b998 ("net: virtio: unify code to init stats") accidentally
> > removed their initialization. In the worst case this can trigger the BUG
> > at lib/dynamic_queue_limits.c:99 because dql_completed() receives a
> > random value as count. Initialize the whole structure.
> > 
> > Fixes: 23c81a20b998 ("net: virtio: unify code to init stats")
> > Reported-by: Aishwarya TCV <[email-masked]>
> > Signed-off-by: Jean-Philippe Brucker <[email-masked]>
> 
> 
> Acked-by: Michael S. Tsirkin <[email-masked]>
> 
> > ---
> > Both these patches are still in next so it might be possible to fix it
> > up directly.
> 
> I'd be fine with squashing but I don't think it's done in net-next.

True, but this patch doesn't apply to net-next.
And 23c81a20b998 ("net: virtio: unify code to init stats")
isn't present in net-next.

...