From: Jakub Kicinski <kuba@kernel•org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel•org>
Cc: mptcp@lists•linux.dev, Mat Martineau <martineau@kernel•org>,
Geliang Tang <geliang@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Shuah Khan <shuah@kernel•org>,
netdev@vger•kernel.org, linux-kselftest@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next] selftests: mptcp: lib: fix shellcheck errors
Date: Sat, 13 Jul 2024 15:46:14 -0700 [thread overview]
Message-ID: <20240713154614.653f30ce@kernel.org> (raw)
In-Reply-To: <20240712-upstream-net-next-20240712-selftests-mptcp-fix-shellcheck-v1-1-1cb7180db40a@kernel.org>
On Fri, 12 Jul 2024 12:00:15 +0200 Matthieu Baerts (NGI0) wrote:
> It looks like we missed these two errors recently:
>
> - SC2068: Double quote array expansions to avoid re-splitting elements.
> - SC2145: Argument mixes string and array. Use * or separate argument.
>
> Two simple fixes, it is not supposed to change the behaviour as the
> variable names should not have any spaces in their names. Still, better
> to fix them to easily spot new issues.
>
> Fixes: f265d3119a29 ("selftests: mptcp: lib: use setup/cleanup_ns helpers")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel•org>
Speaking of MPTCP tests - I added the connect test to ignored today.
Too many failures :(
next prev parent reply other threads:[~2024-07-13 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 10:00 [PATCH net-next] selftests: mptcp: lib: fix shellcheck errors Matthieu Baerts (NGI0)
2024-07-12 18:24 ` Simon Horman
2024-07-13 22:46 ` Jakub Kicinski [this message]
2024-07-15 9:07 ` Matthieu Baerts
2024-07-15 16:44 ` Jakub Kicinski
2024-07-13 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713154614.653f30ce@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=geliang@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=martineau@kernel$(echo .)org \
--cc=matttbe@kernel$(echo .)org \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox