From: Vladimir Oltean <vladimir.oltean@nxp•com>
To: "Mogilappagari, Sudheer" <sudheer.mogilappagari@intel•com>
Cc: Michal Kubecek <mkubecek@suse•cz>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Wei Fang <wei.fang@nxp•com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel•com>
Subject: Re: Netlink handler for ethtool --show-rxfh breaks driver compatibility
Date: Mon, 15 Jul 2024 14:58:07 +0300 [thread overview]
Message-ID: <20240715115807.uc5nbc53rmthdbpu@skbuf> (raw)
In-Reply-To: <IA1PR11MB626638AF6428C3E669F3FD4FE4A12@IA1PR11MB6266.namprd11.prod.outlook.com>
Hi Sudheer,
On Mon, Jul 15, 2024 at 07:37:45AM +0000, Mogilappagari, Sudheer wrote:
> Hi Vladimir,
>
> Here is related discussion wrt this topic https://lore.kernel.org/netdev/IA1PR11MB626656578C50634B3C90E0C4E40E9@IA1PR11MB6266.namprd11.prod.outlook.com/T/#mdfcc6e25edb5b7719356db4759dc13e2a9020487
>
> While introducing netlink support for ethtool --show-rxfh
> the tradeoff was whether to modify the command output or to
> use ETHTOOL_GCHANNELS to get the queue count. We went with
> not modifying command output. Didn't realize about drivers
> with no get_channels() support. Currently I have no ideas
> on how to resolve this other than drivers implementing
> get_channels() support. Any other ideas are welcome.
>
> Though not a solution, one workaround is to compile ethtool
> with no netlink support.
>
> Thanks
> Sudheer
I guess the bottom line is that ETHTOOL_GRXRINGS != ETHTOOL_GCHANNELS.
There is a fair amount of drivers which implements ethtool_ops ::
get_rxnfc() :: struct ethtool_rxnfc->cmd == ETHTOOL_GRXRINGS differently
than ethtool_ops :: get_channels().
Looking at Documentation/networking/ethtool-netlink.rst, I see
ETHTOOL_GRXRINGS has no netlink equivalent. So print_indir_table()
should still be called with the result of the ETHTOOL_GRXRINGS ioctl
even in the netlink case?
next prev parent reply other threads:[~2024-07-15 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:45 Netlink handler for ethtool --show-rxfh breaks driver compatibility Vladimir Oltean
2024-07-15 7:37 ` Mogilappagari, Sudheer
2024-07-15 11:58 ` Vladimir Oltean [this message]
2024-07-15 13:11 ` Jakub Kicinski
2024-07-15 13:22 ` Vladimir Oltean
2024-07-15 13:39 ` Jakub Kicinski
2024-07-15 15:05 ` Vladimir Oltean
2024-07-15 15:26 ` Jakub Kicinski
2024-07-15 15:45 ` Michal Kubecek
2024-07-15 15:46 ` Vladimir Oltean
2024-07-17 16:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715115807.uc5nbc53rmthdbpu@skbuf \
--to=vladimir.oltean@nxp$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=sudheer.mogilappagari@intel$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox