From: Bjorn Helgaas <helgaas@kernel•org>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, pavan.chebbi@broadcom•com,
andrew.gospodarek@broadcom•com,
Kalesh AP <kalesh-anakkur.purayil@broadcom•com>,
Somnath Kotur <somnath.kotur@broadcom•com>,
Hongguang Gao <hongguang.gao@broadcom•com>
Subject: Re: [PATCH net-next 5/9] bnxt_en: Remove BNXT_FLAG_USING_MSIX flag
Date: Mon, 15 Jul 2024 12:32:52 -0500 [thread overview]
Message-ID: <20240715173252.GA435752@bhelgaas> (raw)
In-Reply-To: <20240713234339.70293-6-michael.chan@broadcom.com>
On Sat, Jul 13, 2024 at 04:43:35PM -0700, Michael Chan wrote:
> Now that we only support MSIX, the BNXT_FLAG_USING_MSIX is always true.
> Remove it and any if conditions checking for it. Remove the INTX
> handler and associated logic.
The cover letter says new firmware (the revision isn't mentioned)
doesn't support INTx. I guess it's OK if the new driver without INTx
support runs on adapters with old firmware that still supports INTx?
So the INTx support was never a real benefit? I assume this driver
change won't force a simultaneous firmware update? The old driver
might work in a "pci=nomsi" situation, but the new one probably won't?
Just checking to be sure these are all acceptable consequences.
next prev parent reply other threads:[~2024-07-15 17:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 23:43 [PATCH net-next 0/9] bnxt_en: Update for net-next Michael Chan
2024-07-13 23:43 ` [PATCH net-next 1/9] bnxt_en: add support for storing crash dump into host memory Michael Chan
2024-07-15 9:28 ` Simon Horman
2024-07-13 23:43 ` [PATCH net-next 2/9] bnxt_en: add support for retrieving crash dump using ethtool Michael Chan
2024-07-15 9:28 ` Simon Horman
2024-07-13 23:43 ` [PATCH net-next 3/9] bnxt_en: Support QOS and TPID settings for the SRIOV VLAN Michael Chan
2024-07-15 9:17 ` Simon Horman
2024-07-13 23:43 ` [PATCH net-next 4/9] bnxt_en: Deprecate support for legacy INTX mode Michael Chan
2024-07-15 9:28 ` Simon Horman
2024-07-15 16:24 ` Michael Chan
2024-07-16 16:57 ` Dan Carpenter
2024-07-16 17:28 ` Michael Chan
2024-07-13 23:43 ` [PATCH net-next 5/9] bnxt_en: Remove BNXT_FLAG_USING_MSIX flag Michael Chan
2024-07-15 9:29 ` Simon Horman
2024-07-15 17:32 ` Bjorn Helgaas [this message]
2024-07-15 18:00 ` Michael Chan
2024-07-13 23:43 ` [PATCH net-next 6/9] bnxt_en: Remove register mapping to support INTX Michael Chan
2024-07-15 9:30 ` Simon Horman
2024-07-15 17:27 ` Bjorn Helgaas
2024-07-13 23:43 ` [PATCH net-next 7/9] bnxt_en: Replace deprecated PCI MSIX APIs Michael Chan
2024-07-15 9:30 ` Simon Horman
2024-07-13 23:43 ` [PATCH net-next 8/9] bnxt_en: Allocate the max bp->irq_tbl size for dynamic msix allocation Michael Chan
2024-07-15 9:30 ` Simon Horman
2024-07-15 17:33 ` Bjorn Helgaas
2024-07-13 23:43 ` [PATCH net-next 9/9] bnxt_en: Support dynamic MSIX Michael Chan
2024-07-15 9:31 ` Simon Horman
2024-07-15 17:34 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715173252.GA435752@bhelgaas \
--to=helgaas@kernel$(echo .)org \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hongguang.gao@broadcom$(echo .)com \
--cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox