Subject: Re: [PATCH iwl-next v3 05/13] ice: add parser execution main loop

From: Simon Horman <[email-masked]>
Date: Mon, 22 Jul 2024 16:01:36 +0100

On Wed, Jul 10, 2024 at 02:40:07PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo <[email-masked]>
> 
> Implement the core work of the runtime parser via:
> - ice_parser_rt_execute()
> - ice_parser_rt_reset()
> - ice_parser_rt_pkt_buf_set()
> 
> Reviewed-by: Marcin Szycik <[email-masked]>
> Signed-off-by: Qi Zhang <[email-masked]>
> Signed-off-by: Junfeng Guo <[email-masked]>
> Signed-off-by: Ahmed Zaki <[email-masked]>

> diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/ethernet/intel/ice/ice_parser_rt.c

...

> +static u16 ice_ptype_resolve(struct ice_parser_rt *rt)
> +{
> +	struct ice_parser *psr = rt->psr;
> +	struct ice_ptype_mk_tcam_item *item;

nit: Please consider arranging these variables in reverse xmas tree order.

     Flagged by https://github.com/ecree-solarflare/xmastree

> +
> +	item = ice_ptype_mk_tcam_match(psr->ptype_mk_tcam_table,
> +				       rt->markers, ICE_MARKER_ID_SIZE);
> +	if (item)
> +		return item->ptype;
> +
> +	ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Could not resolve PTYPE\n");
> +	return U16_MAX;
> +}

...