Subject: Re: [PATCH v1 net] l2tp: Don't assign net->gen->ptr[] for pppol2tp_net_ops.

From: Simon Horman <[email-masked]>
Date: Tue, 23 Jul 2024 09:50:23 +0100

On Mon, Jul 22, 2024 at 12:15:56PM -0700, Kuniyuki Iwashima wrote:
> Commit fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and
> ppp parts") converted net->gen->ptr[pppol2tp_net_id] in l2tp_ppp.c to
> net->gen->ptr[l2tp_net_id] in l2tp_core.c.
> 
> Now the leftover wastes one entry of net->gen->ptr[] in each netns.
> 
> Let's avoid the unwanted allocation.
> 
> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> Signed-off-by: Kuniyuki Iwashima <[email-masked]>

Hi Iwashima-san,

It looks like this problem is a resource overuse that has been present
since 2010. So I lean towards it being a clean-up for net-next rather than
a fix.

That notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>

...