public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
	Jakub Kicinski <kuba@kernel•org>,
	donald.hunter@gmail•com, kory.maincent@bootlin•com,
	sdf@fomichev•me
Subject: [PATCH net 1/2] netlink: specs: correct the spec of ethtool
Date: Wed, 24 Jul 2024 16:42:48 -0700	[thread overview]
Message-ID: <20240724234249.2621109-2-kuba@kernel.org> (raw)
In-Reply-To: <20240724234249.2621109-1-kuba@kernel.org>

The spec for Ethtool is a bit inaccurate. We don't currently
support dump. Context is only accepted as input and not echoed
to output (which is a separate bug).

Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
CC: donald.hunter@gmail•com
CC: kory.maincent@bootlin•com
CC: sdf@fomichev•me
---
 Documentation/netlink/specs/ethtool.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 495e35fcfb21..ebbd8dd96b5c 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -1753,15 +1753,14 @@ doc: Partial family for Ethtool Netlink.
         request:
           attributes:
             - header
+            - context
         reply:
           attributes:
             - header
-            - context
             - hfunc
             - indir
             - hkey
             - input_xfrm
-      dump: *rss-get-op
     -
       name: plca-get-cfg
       doc: Get PLCA params.
-- 
2.45.2


  reply	other threads:[~2024-07-24 23:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 23:42 [PATCH net 0/2] ethtool: rss: small fixes to spec and GET Jakub Kicinski
2024-07-24 23:42 ` Jakub Kicinski [this message]
2024-08-11  8:25   ` [PATCH net 1/2] netlink: specs: correct the spec of ethtool Kory Maincent
2024-07-24 23:42 ` [PATCH net 2/2] ethtool: rss: echo the context number back Jakub Kicinski
2024-08-11  8:27   ` Kory Maincent
2024-07-25 11:30 ` [PATCH net 0/2] ethtool: rss: small fixes to spec and GET Paolo Abeni
2024-07-25 17:36 ` Joe Damato
2024-07-25 23:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240724234249.2621109-2-kuba@kernel.org \
    --to=kuba@kernel$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=donald.hunter@gmail$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=kory.maincent@bootlin$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=sdf@fomichev$(echo .)me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox