From: Jakub Kicinski <kuba@kernel•org>
To: Justin Lai <justinlai0215@realtek•com>
Cc: "davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"andrew@lunn•ch" <andrew@lunn•ch>,
"jiri@resnulli•us" <jiri@resnulli•us>,
"horms@kernel•org" <horms@kernel•org>,
"rkannoth@marvell•com" <rkannoth@marvell•com>,
"jdamato@fastly•com" <jdamato@fastly•com>,
Ping-Ke Shih <pkshih@realtek•com>,
Larry Chiu <larry.chiu@realtek•com>
Subject: Re: [PATCH net-next v25 06/13] rtase: Implement .ndo_start_xmit function
Date: Tue, 30 Jul 2024 07:12:14 -0700 [thread overview]
Message-ID: <20240730071214.375dc4ff@kernel.org> (raw)
In-Reply-To: <f43b61ec5e624ae78dc5d564e8735ef3@realtek.com>
On Tue, 30 Jul 2024 09:27:27 +0000 Justin Lai wrote:
> > Please fix these issues in the driver you're copying from, too.
>
> I will inform the person responsible for the R8169 of the issues we've
> identified and discuss what modifications need to be made.
That sounds quite noncommittal. Please fix r8169 _before_ you post
the next version of this cop^W driver.
next prev parent reply other threads:[~2024-07-30 14:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 6:21 [PATCH net-next v25 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-07-29 9:33 ` Markus Elfring
2024-07-29 11:31 ` Justin Lai
2024-07-29 13:00 ` Andrew Lunn
2024-07-29 16:44 ` Markus Elfring
2024-07-29 6:21 ` [PATCH net-next v25 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-07-30 2:15 ` Jakub Kicinski
2024-07-30 9:24 ` Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 03/13] rtase: Implement the rtase_down function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 05/13] rtase: Implement hardware configuration function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-07-30 2:14 ` Jakub Kicinski
2024-07-30 9:27 ` Justin Lai
2024-07-30 14:12 ` Jakub Kicinski [this message]
2024-07-30 19:34 ` Heiner Kallweit
2024-07-29 6:21 ` [PATCH net-next v25 07/13] rtase: Implement a function to receive packets Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 08/13] rtase: Implement net_device_ops Justin Lai
2024-07-29 10:29 ` Joe Damato
2024-07-29 11:39 ` Justin Lai
2024-07-29 11:56 ` Joe Damato
2024-07-29 12:26 ` Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 10/13] rtase: Implement ethtool function Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-07-29 6:21 ` [PATCH net-next v25 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730071214.375dc4ff@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=justinlai0215@realtek$(echo .)com \
--cc=larry.chiu@realtek$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pkshih@realtek$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox