From: Simon Horman <horms@kernel•org>
To: jitendra.vegiraju@broadcom•com
Cc: netdev@vger•kernel.org, alexandre.torgue@foss•st.com,
joabreu@synopsys•com, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, mcoquelin.stm32@gmail•com,
bcm-kernel-feedback-list@broadcom•com, richardcochran@gmail•com,
ast@kernel•org, daniel@iogearbox•net, hawk@kernel•org,
john.fastabend@gmail•com, linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, bpf@vger•kernel.org,
andrew@lunn•ch, linux@armlinux•org.uk,
florian.fainelli@broadcom•com
Subject: Re: [PATCH net-next v3 1/3] net: stmmac: Add basic dwxgmac4 support to stmmac core
Date: Fri, 2 Aug 2024 15:38:18 +0100 [thread overview]
Message-ID: <20240802143818.GB2504122@kernel.org> (raw)
In-Reply-To: <20240802031822.1862030-2-jitendra.vegiraju@broadcom.com>
On Thu, Aug 01, 2024 at 08:18:20PM -0700, jitendra.vegiraju@broadcom•com wrote:
> From: Jitendra Vegiraju <jitendra.vegiraju@broadcom•com>
>
> Adds support for DWC_xgmac version 4.00a in stmmac core module.
> This version adds enhancements to DMA architecture for virtualization
> scalability. This is realized by decoupling physical DMA channels (PDMA)
> from Virtual DMA channels (VDMA). The VDMAs are software abastractions
> that map to PDMAs for frame transmission and reception.
>
> The virtualization enhancements are currently not being used and hence
> a fixed mapping of VDMA to PDMA is configured in the init functions.
> Because of the new init functions, a new instance of struct stmmac_dma_ops
> dwxgmac400_dma_ops is added.
> Most of the other dma operation functions in existing dwxgamc2_dma.c file
> can be reused.
>
> Signed-off-by: Jitendra Vegiraju <jitendra.vegiraju@broadcom•com>
...
> stmmac-$(CONFIG_STMMAC_SELFTESTS) += stmmac_selftests.o
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
...
> @@ -641,3 +642,33 @@ const struct stmmac_dma_ops dwxgmac210_dma_ops = {
> .enable_sph = dwxgmac2_enable_sph,
> .enable_tbs = dwxgmac2_enable_tbs,
> };
> +
> +const struct stmmac_dma_ops dwxgmac400_dma_ops = {
> + .reset = dwxgmac2_dma_reset,
> + .init = dwxgmac4_dma_init,
> + .init_chan = dwxgmac2_dma_init_chan,
> + .init_rx_chan = dwxgmac4_dma_init_rx_chan,
> + .init_tx_chan = dwxgmac4_dma_init_tx_chan,
> + .axi = dwxgmac2_dma_axi,
> + .dump_regs = dwxgmac2_dma_dump_regs,
> + .dma_rx_mode = dwxgmac2_dma_rx_mode,
> + .dma_tx_mode = dwxgmac2_dma_tx_mode,
> + .enable_dma_irq = dwxgmac2_enable_dma_irq,
> + .disable_dma_irq = dwxgmac2_disable_dma_irq,
> + .start_tx = dwxgmac2_dma_start_tx,
> + .stop_tx = dwxgmac2_dma_stop_tx,
> + .start_rx = dwxgmac2_dma_start_rx,
> + .stop_rx = dwxgmac2_dma_stop_rx,
> + .dma_interrupt = dwxgmac2_dma_interrupt,
> + .get_hw_feature = dwxgmac2_get_hw_feature,
> + .rx_watchdog = dwxgmac2_rx_watchdog,
> + .set_rx_ring_len = dwxgmac2_set_rx_ring_len,
> + .set_tx_ring_len = dwxgmac2_set_tx_ring_len,
> + .set_rx_tail_ptr = dwxgmac2_set_rx_tail_ptr,
> + .set_tx_tail_ptr = dwxgmac2_set_tx_tail_ptr,
> + .enable_tso = dwxgmac2_enable_tso,
> + .qmode = dwxgmac2_qmode,
> + .set_bfsize = dwxgmac2_set_bfsize,
> + .enable_sph = dwxgmac2_enable_sph,
> + .enable_tbs = dwxgmac2_enable_tbs,
> +};
Please add dwxgmac400_dma_ops to hwif.h in this patch rather than a
subsequent one to avoid Sparse suggesting the symbol should be static.
...
next prev parent reply other threads:[~2024-08-02 14:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 3:18 [PATCH net-next v3 0/3] net: stmmac: Add PCI driver support for BCM8958x jitendra.vegiraju
2024-08-02 3:18 ` [PATCH net-next v3 1/3] net: stmmac: Add basic dwxgmac4 support to stmmac core jitendra.vegiraju
2024-08-02 8:21 ` Russell King (Oracle)
2024-08-02 21:43 ` Jitendra Vegiraju
2024-08-02 14:38 ` Simon Horman [this message]
2024-08-02 21:45 ` Jitendra Vegiraju
2024-08-06 21:56 ` Serge Semin
2024-08-09 0:41 ` Jitendra Vegiraju
2024-08-02 3:18 ` [PATCH net-next v3 2/3] net: stmmac: Integrate dwxgmac4 into stmmac hwif handling jitendra.vegiraju
2024-08-02 8:23 ` Russell King (Oracle)
2024-08-02 21:49 ` Jitendra Vegiraju
2024-08-02 22:59 ` Andrew Lunn
2024-08-06 0:36 ` Jitendra Vegiraju
2024-08-06 23:13 ` Andrew Lunn
2024-08-09 1:49 ` Jitendra Vegiraju
2024-08-06 22:14 ` Serge Semin
2024-08-09 1:17 ` Jitendra Vegiraju
2024-08-02 3:18 ` [PATCH net-next v3 3/3] net: stmmac: Add PCI driver support for BCM8958x jitendra.vegiraju
2024-08-02 23:08 ` Andrew Lunn
2024-08-06 0:56 ` Jitendra Vegiraju
2024-08-06 23:15 ` Andrew Lunn
2024-08-09 1:54 ` Jitendra Vegiraju
2024-08-09 20:12 ` Andrew Lunn
2024-08-09 22:10 ` Jitendra Vegiraju
2024-08-09 22:17 ` Florian Fainelli
2024-08-10 0:53 ` Andrew Lunn
2024-08-02 10:02 ` [PATCH net-next v3 0/3] " Serge Semin
2024-08-02 22:06 ` Jitendra Vegiraju
2024-08-05 22:43 ` Serge Semin
2024-08-08 23:03 ` Jitendra Vegiraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802143818.GB2504122@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew@lunn$(echo .)ch \
--cc=ast@kernel$(echo .)org \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=jitendra.vegiraju@broadcom$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox