public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Simon Horman <horms@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
	pabeni@redhat•com, kernel test robot <lkp@intel•com>,
	alexanderduyck@fb•com
Subject: Re: [PATCH net] eth: fbnic: select devlink
Date: Fri, 2 Aug 2024 15:50:38 +0100	[thread overview]
Message-ID: <20240802145038.GE2504122@kernel.org> (raw)
In-Reply-To: <20240802015924.624368-1-kuba@kernel.org>

On Thu, Aug 01, 2024 at 06:59:24PM -0700, Jakub Kicinski wrote:
> Build bot reports undefined references to devlink functions
> in fbnic.ko.
> 
> Fixes: 1a9d48892ea5 ("eth: fbnic: Allocate core device specific structures and devlink interface")
> Reported-by: kernel test robot <lkp@intel•com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408011219.hiPmwwAs-lkp@intel.com/
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>

Thanks, I agree this is needed.

Reviewed-by: Simon Horman <horms@kernel•org>
Tested-by: Simon Horman <horms@kernel•org>

But while exercising this I noticed that PAGE_POOL is also needed,
which I locally resolved by adding:

	select PAGE_POOL

I can provide a follow-up patch after this one is merged.
Or perhaps you can address this in a v2?
I have no preference either way.

next prev parent reply	other threads:[~2024-08-02 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02  1:59 [PATCH net] eth: fbnic: select devlink Jakub Kicinski
2024-08-02 14:50 ` Simon Horman [this message]
2024-08-02 15:01   ` Jakub Kicinski
2024-08-02 15:31     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240802145038.GE2504122@kernel.org \
    --to=horms@kernel$(echo .)org \
    --cc=alexanderduyck@fb$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=lkp@intel$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox