From: Moon Yeounsu <yyyynoom@gmail•com>
To: cooldavid@cooldavid•org, davem@davemloft•net, kuba@kernel•org,
pabeni@redhat•com
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
christophe.jaillet@wanadoo•fr, horms@kernel•org,
Moon Yeounsu <yyyynoom@gmail•com>
Subject: [PATCH v2] net: ethernet: remove unnecessary parentheses
Date: Sat, 3 Aug 2024 11:29:49 +0900 [thread overview]
Message-ID: <20240803022949.28229-1-yyyynoom@gmail.com> (raw)
In-Reply-To: <20240802054421.5428-1-yyyynoom@gmail.com>
remove unnecessary parentheses surrounding `ip_hdrlen()`,
And keep it under 80 columns long to follow the kernel coding style.
Signed-off-by: Moon Yeounsu <yyyynoom@gmail•com>
---
drivers/net/ethernet/jme.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 83b185c995df..d8be0e4dcb07 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -947,12 +947,12 @@ jme_udpsum(struct sk_buff *skb)
return csum;
skb_set_network_header(skb, ETH_HLEN);
- if ((ip_hdr(skb)->protocol != IPPROTO_UDP) ||
- (skb->len < (ETH_HLEN + (ip_hdrlen(skb)) + sizeof(struct udphdr)))) {
+ if (ip_hdr(skb)->protocol != IPPROTO_UDP ||
+ skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) {
skb_reset_network_header(skb);
return csum;
}
- skb_set_transport_header(skb, ETH_HLEN + (ip_hdrlen(skb)));
+ skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb));
csum = udp_hdr(skb)->check;
skb_reset_transport_header(skb);
skb_reset_network_header(skb);
--
2.45.2
next prev parent reply other threads:[~2024-08-03 2:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 5:44 [PATCH] net: ethernet: use ip_hdrlen() instead of bit shift Moon Yeounsu
2024-08-02 13:35 ` Christophe JAILLET
2024-08-03 1:21 ` Moon Yeounsu
2024-08-02 14:15 ` Simon Horman
2024-08-02 14:40 ` Simon Horman
2024-08-03 1:47 ` Moon Yeounsu
2024-08-04 10:18 ` Simon Horman
2024-08-05 0:32 ` Guo-Fu Tseng
2024-08-03 2:29 ` Moon Yeounsu [this message]
2024-08-03 10:22 ` [PATCH v2] net: ethernet: remove unnecessary parentheses Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240803022949.28229-1-yyyynoom@gmail.com \
--to=yyyynoom@gmail$(echo .)com \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=cooldavid@cooldavid$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox