From: Jakub Kicinski <kuba@kernel•org>
To: Mina Almasry <almasrymina@google•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-doc@vger•kernel.org, linux-alpha@vger•kernel.org,
linux-mips@vger•kernel.org, linux-parisc@vger•kernel.org,
sparclinux@vger•kernel.org, linux-trace-kernel@vger•kernel.org,
linux-arch@vger•kernel.org, linux-kselftest@vger•kernel.org,
bpf@vger•kernel.org, linux-media@vger•kernel.org,
dri-devel@lists•freedesktop.org,
"Donald Hunter" <donald.hunter@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Jonathan Corbet" <corbet@lwn•net>,
"Richard Henderson" <richard.henderson@linaro•org>,
"Ivan Kokshaysky" <ink@jurassic•park.msu.ru>,
"Matt Turner" <mattst88@gmail•com>,
"Thomas Bogendoerfer" <tsbogend@alpha•franken.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
"Helge Deller" <deller@gmx•de>,
"Andreas Larsson" <andreas@gaisler•com>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro•org>,
"Steven Rostedt" <rostedt@goodmis•org>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios•com>,
"Arnd Bergmann" <arnd@arndb•de>,
"Steffen Klassert" <steffen.klassert@secunet•com>,
"Herbert Xu" <herbert@gondor•apana.org.au>,
"David Ahern" <dsahern@kernel•org>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail•com>,
"Shuah Khan" <shuah@kernel•org>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
"Christian König" <christian.koenig@amd•com>,
"Bagas Sanjaya" <bagasdotme@gmail•com>,
"Christoph Hellwig" <hch@infradead•org>,
"Nikolay Aleksandrov" <razor@blackwall•org>,
"Taehee Yoo" <ap420073@gmail•com>,
"Pavel Begunkov" <asml.silence@gmail•com>,
"David Wei" <dw@davidwei•uk>, "Jason Gunthorpe" <jgg@ziepe•ca>,
"Yunsheng Lin" <linyunsheng@huawei•com>,
"Shailend Chand" <shailend@google•com>,
"Harshitha Ramamurthy" <hramamurthy@google•com>,
"Shakeel Butt" <shakeel.butt@linux•dev>,
"Jeroen de Borst" <jeroendb@google•com>,
"Praveen Kaligineedi" <pkaligineedi@google•com>
Subject: Re: [PATCH net-next v18 05/14] page_pool: move dmaddr helpers to .c file
Date: Tue, 6 Aug 2024 13:42:54 -0700 [thread overview]
Message-ID: <20240806134254.265e2bfb@kernel.org> (raw)
In-Reply-To: <20240805212536.2172174-6-almasrymina@google.com>
On Mon, 5 Aug 2024 21:25:18 +0000 Mina Almasry wrote:
> +dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem)
> +{
> + struct page *page = netmem_to_page(netmem);
> +
> + dma_addr_t ret = page->dma_addr;
> +
> + if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA)
> + ret <<= PAGE_SHIFT;
> +
> + return ret;
> +}
> +EXPORT_SYMBOL(page_pool_get_dma_addr_netmem);
Get should stay in the header.
> +bool page_pool_set_dma_addr_netmem(netmem_ref netmem, dma_addr_t addr)
> +{
> + struct page *page = netmem_to_page(netmem);
> +
> + if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) {
> + page->dma_addr = addr >> PAGE_SHIFT;
> +
> + /* We assume page alignment to shave off bottom bits,
> + * if this "compression" doesn't work we need to drop.
> + */
> + return addr != (dma_addr_t)page->dma_addr << PAGE_SHIFT;
> + }
> +
> + page->dma_addr = addr;
> + return false;
> +}
> +EXPORT_SYMBOL(page_pool_set_dma_addr_netmem);
Set should not be in the public (include/linux) header at all,
and should not be exported. net/core/page_pool_priv.h already
exists. Feel free to break this out of the series.
next prev parent reply other threads:[~2024-08-06 20:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 21:25 [PATCH net-next v18 00/14] Device Memory TCP Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 01/14] netdev: add netdev_rx_queue_restart() Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 02/14] net: netdev netlink api to bind dma-buf to a net device Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 03/14] netdev: support binding dma-buf to netdevice Mina Almasry
2024-08-06 20:37 ` Jakub Kicinski
2024-08-05 21:25 ` [PATCH net-next v18 04/14] netdev: netdevice devmem allocator Mina Almasry
2024-08-06 20:47 ` Jakub Kicinski
2024-08-05 21:25 ` [PATCH net-next v18 05/14] page_pool: move dmaddr helpers to .c file Mina Almasry
2024-08-06 20:42 ` Jakub Kicinski [this message]
2024-08-05 21:25 ` [PATCH net-next v18 06/14] page_pool: devmem support Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider Mina Almasry
2024-08-06 20:59 ` Jakub Kicinski
2024-08-08 20:36 ` Mina Almasry
2024-08-09 2:24 ` Jakub Kicinski
2024-08-09 14:10 ` Mina Almasry
2024-08-09 15:45 ` Pavel Begunkov
2024-08-10 3:52 ` Jakub Kicinski
2024-08-11 2:21 ` Mina Almasry
2024-08-11 21:51 ` Pavel Begunkov
2024-08-12 17:57 ` Jakub Kicinski
2024-08-12 18:55 ` Mina Almasry
2024-08-12 19:10 ` Pavel Begunkov
2024-08-12 23:57 ` Jakub Kicinski
2024-08-13 2:31 ` Pavel Begunkov
2024-08-13 14:39 ` Jakub Kicinski
2024-08-13 15:11 ` Pavel Begunkov
2024-08-13 15:26 ` Jakub Kicinski
2024-08-12 18:57 ` Pavel Begunkov
2024-08-12 19:04 ` Pavel Begunkov
2024-08-13 0:15 ` Jakub Kicinski
2024-08-13 1:56 ` Pavel Begunkov
2024-08-13 8:39 ` Mina Almasry
2024-08-13 9:03 ` Mina Almasry
2024-08-13 14:33 ` Jakub Kicinski
2024-08-05 21:25 ` [PATCH net-next v18 08/14] net: support non paged skb frags Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 09/14] net: add support for skbs with unreadable frags Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 10/14] tcp: RX path for devmem TCP Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 11/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 12/14] net: add devmem TCP documentation Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 13/14] selftests: add ncdevmem, netcat for devmem TCP Mina Almasry
2024-08-05 21:25 ` [PATCH net-next v18 14/14] netdev: add dmabuf introspection Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806134254.265e2bfb@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andreas@gaisler$(echo .)com \
--cc=ap420073@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=asml.silence@gmail$(echo .)com \
--cc=bagasdotme@gmail$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christian.koenig@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsahern@kernel$(echo .)org \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hch@infradead$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hramamurthy@google$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jeroendb@google$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=linyunsheng@huawei$(echo .)com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mattst88@gmail$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pkaligineedi@google$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=richard.henderson@linaro$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=shailend@google$(echo .)com \
--cc=shakeel.butt@linux$(echo .)dev \
--cc=shuah@kernel$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox