From: Rob Herring <robh@kernel•org>
To: vtpieter@gmail•com
Cc: devicetree@vger•kernel.org, woojung.huh@microchip•com,
UNGLinuxDriver@microchip•com, netdev@vger•kernel.org,
o.rempel@pengutronix•de,
Pieter Van Trappen <pieter.van.trappen@cern•ch>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: add microchip,no-tag-protocol flag
Date: Tue, 6 Aug 2024 11:17:04 -0600 [thread overview]
Message-ID: <20240806171704.GA1749400-robh@kernel.org> (raw)
In-Reply-To: <20240801123143.622037-2-vtpieter@gmail.com>
On Thu, Aug 01, 2024 at 02:31:42PM +0200, vtpieter@gmail•com wrote:
> From: Pieter Van Trappen <pieter.van.trappen@cern•ch>
>
> Add microchip,no-tag-protocol flag to allow disabling the switch'
What is the ' for?
> tagging protocol. For cases where the CPU MAC does not support MTU
> size > 1500 such as the Zynq GEM.
What is "switch tag protocol"? Not defined anywhere? Is that VLAN
tagging?
It seems to me that this doesn't need to be in DT. You know you have
Zynq GEM because it should have a specific compatible. If it doesn't
support some feature, then that should get propagated to the switch
somehow.
Rob
next prev parent reply other threads:[~2024-08-06 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:31 [PATCH net-next 0/2] implement microchip,no-tag-protocol flag vtpieter
2024-08-01 12:31 ` [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: add " vtpieter
2024-08-06 17:17 ` Rob Herring [this message]
2024-08-08 10:24 ` Pieter
2024-08-01 12:31 ` [PATCH net-next 2/2] net: dsa: microchip: implement " vtpieter
2024-08-01 13:44 ` [PATCH net-next 0/2] " Vladimir Oltean
2024-08-01 13:52 ` Vladimir Oltean
2024-08-01 15:37 ` Pieter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806171704.GA1749400-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pieter.van.trappen@cern$(echo .)ch \
--cc=vtpieter@gmail$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox