From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
michael.chan@broadcom•com, shuah@kernel•org,
ecree.xilinx@gmail•com, przemyslaw.kitszel@intel•com,
ahmed.zaki@intel•com, andrew@lunn•ch, willemb@google•com,
pavan.chebbi@broadcom•com, petrm@nvidia•com, gal@nvidia•com,
jdamato@fastly•com, donald.hunter@gmail•com,
Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next v3 05/12] eth: remove .cap_rss_ctx_supported from updated drivers
Date: Tue, 6 Aug 2024 12:33:10 -0700 [thread overview]
Message-ID: <20240806193317.1491822-6-kuba@kernel.org> (raw)
In-Reply-To: <20240806193317.1491822-1-kuba@kernel.org>
Remove .cap_rss_ctx_supported from drivers which moved to the new API.
This makes it easy to grep for drivers which still need to be converted.
Reviewed-by: Gal Pressman <gal@nvidia•com>
Reviewed-by: Edward Cree <ecree.xilinx@gmail•com>
Reviewed-by: Joe Damato <jdamato@fastly•com>
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 -
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 -
drivers/net/ethernet/sfc/ef100_ethtool.c | 1 -
drivers/net/ethernet/sfc/ethtool.c | 1 -
4 files changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index ab8e3f197e7b..33e8cf0a3764 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -5289,7 +5289,6 @@ void bnxt_ethtool_free(struct bnxt *bp)
const struct ethtool_ops bnxt_ethtool_ops = {
.cap_link_lanes_supported = 1,
- .cap_rss_ctx_supported = 1,
.rxfh_max_context_id = BNXT_MAX_ETH_RSS_CTX,
.rxfh_indir_space = BNXT_MAX_RSS_TABLE_ENTRIES_P5,
.rxfh_priv_size = sizeof(struct bnxt_rss_ctx),
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index b70aca33b928..98500b70f994 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -5791,7 +5791,6 @@ static const struct net_device_ops mvpp2_netdev_ops = {
};
static const struct ethtool_ops mvpp2_eth_tool_ops = {
- .cap_rss_ctx_supported = true,
.rxfh_max_context_id = MVPP22_N_RSS_TABLES - 1,
.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
ETHTOOL_COALESCE_MAX_FRAMES,
diff --git a/drivers/net/ethernet/sfc/ef100_ethtool.c b/drivers/net/ethernet/sfc/ef100_ethtool.c
index 896ffca4aee2..746b5314acb5 100644
--- a/drivers/net/ethernet/sfc/ef100_ethtool.c
+++ b/drivers/net/ethernet/sfc/ef100_ethtool.c
@@ -37,7 +37,6 @@ ef100_ethtool_get_ringparam(struct net_device *net_dev,
/* Ethtool options available
*/
const struct ethtool_ops ef100_ethtool_ops = {
- .cap_rss_ctx_supported = true,
.get_drvinfo = efx_ethtool_get_drvinfo,
.get_msglevel = efx_ethtool_get_msglevel,
.set_msglevel = efx_ethtool_set_msglevel,
diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
index 7c887160e2ef..15245720c949 100644
--- a/drivers/net/ethernet/sfc/ethtool.c
+++ b/drivers/net/ethernet/sfc/ethtool.c
@@ -240,7 +240,6 @@ static int efx_ethtool_get_ts_info(struct net_device *net_dev,
}
const struct ethtool_ops efx_ethtool_ops = {
- .cap_rss_ctx_supported = true,
.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
ETHTOOL_COALESCE_USECS_IRQ |
ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
--
2.45.2
next prev parent reply other threads:[~2024-08-06 19:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 19:33 [PATCH net-next v3 00/12] ethtool: rss: driver tweaks and netlink context dumps Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 01/12] selftests: drv-net: rss_ctx: add identifier to traffic comments Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 02/12] eth: mvpp2: implement new RSS context API Jakub Kicinski
2024-08-08 11:22 ` Edward Cree
2024-08-06 19:33 ` [PATCH net-next v3 03/12] eth: mlx5: allow disabling queues when RSS contexts exist Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 04/12] ethtool: make ethtool_ops::cap_rss_ctx_supported optional Jakub Kicinski
2024-08-06 19:33 ` Jakub Kicinski [this message]
2024-08-06 19:33 ` [PATCH net-next v3 06/12] ethtool: rss: don't report key if device doesn't support it Jakub Kicinski
2024-08-08 11:26 ` Edward Cree
2024-08-06 19:33 ` [PATCH net-next v3 07/12] ethtool: rss: move the device op invocation out of rss_prepare_data() Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 08/12] ethtool: rss: report info about additional contexts from XArray Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 09/12] ethtool: rss: support dumping RSS contexts Jakub Kicinski
2024-08-08 11:33 ` Edward Cree
2024-08-06 19:33 ` [PATCH net-next v3 10/12] ethtool: rss: support skipping contexts during dump Jakub Kicinski
2024-08-06 19:33 ` [PATCH net-next v3 11/12] netlink: specs: decode indirection table as u32 array Jakub Kicinski
2024-08-07 12:00 ` Joe Damato
2024-08-06 19:33 ` [PATCH net-next v3 12/12] selftests: drv-net: rss_ctx: test dumping RSS contexts Jakub Kicinski
2024-08-08 10:05 ` Petr Machata
2024-08-08 11:42 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806193317.1491822-6-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=jdamato@fastly$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox