Subject: Re: [PATCH net-next 0/5] tc: adjust network header after second vlan push

From: Jakub Kicinski <[email-masked]>
Date: Mon, 12 Aug 2024 17:40:47 -0700

On Mon,  5 Aug 2024 13:56:44 +0300 Boris Sukholitko wrote:
> More about the patch series:
> 
> * patches 1-3 refactor skb_vlan_push to make skb_vlan_flush helper
> * patch 4 open codes skb_vlan_push in act_vlan.c
> * patch 5 contains the actual fix

The series is structured quite nicely for review, so kudos for that.
But I'm not seeing the motivation for changing how TC pushes VLANs
and not changing OvS (or BPF?), IOW the other callers of
skb_vlan_push().

Why would pushing a tag from TC actions behave differently?

Please also add your test case to
tools/testing/selftests/net/forwarding/tc_actions.sh
if you can.