From: Jakub Kicinski <kuba@kernel•org>
To: Jianbo Liu <jianbol@nvidia•com>
Cc: Tariq Toukan <tariqt@nvidia•com>,
"liuhangbin@gmail•com" <liuhangbin@gmail•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"andy@greyhouse•net" <andy@greyhouse•net>,
Gal Pressman <gal@nvidia•com>,
"jv@jvosburgh•net" <jv@jvosburgh•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"edumazet@google•com" <edumazet@google•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leonro@nvidia•com>
Subject: Re: [PATCH net V3 1/3] bonding: implement xdo_dev_state_free and call it after deletion
Date: Tue, 13 Aug 2024 07:14:45 -0700 [thread overview]
Message-ID: <20240813071445.3e5f1cc9@kernel.org> (raw)
In-Reply-To: <14564f4a8e00ecfa149ef1712d06950802e72605.camel@nvidia.com>
On Tue, 13 Aug 2024 02:58:12 +0000 Jianbo Liu wrote:
> > > + rcu_read_lock();
> > > + bond = netdev_priv(bond_dev);
> > > + slave = rcu_dereference(bond->curr_active_slave);
> > > + real_dev = slave ? slave->dev : NULL;
> > > + rcu_read_unlock();
> >
> > What's holding onto real_dev once you drop the rcu lock here?
>
> I think it should be xfrm state (and bond device).
Please explain it in the commit message in more certain terms.
next prev parent reply other threads:[~2024-08-13 14:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 5:03 [PATCH net V3 0/3] Fixes for IPsec over bonding Tariq Toukan
2024-08-05 5:03 ` [PATCH net V3 1/3] bonding: implement xdo_dev_state_free and call it after deletion Tariq Toukan
2024-08-06 8:45 ` Hangbin Liu
2024-08-06 9:09 ` Jianbo Liu
2024-08-07 10:11 ` Hangbin Liu
2024-08-13 0:48 ` Jakub Kicinski
2024-08-13 2:58 ` Jianbo Liu
2024-08-13 14:14 ` Jakub Kicinski [this message]
2024-08-14 2:03 ` Jianbo Liu
2024-08-14 3:11 ` Hangbin Liu
2024-08-15 1:23 ` Jianbo Liu
2024-08-15 3:34 ` Hangbin Liu
2024-08-15 3:57 ` Jianbo Liu
2024-08-05 5:03 ` [PATCH net V3 2/3] bonding: extract the use of real_device into local variable Tariq Toukan
2024-08-07 10:13 ` Hangbin Liu
2024-08-05 5:03 ` [PATCH net V3 3/3] bonding: change ipsec_lock from spin lock to mutex Tariq Toukan
2024-08-08 9:34 ` Hangbin Liu
2024-08-08 10:05 ` Jianbo Liu
2024-08-09 2:31 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813071445.3e5f1cc9@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=jianbol@nvidia$(echo .)com \
--cc=jv@jvosburgh$(echo .)net \
--cc=leonro@nvidia$(echo .)com \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox