Subject: Re: [PATCHv2 net-next] openvswitch: switch to per-action label counting in conntrack

From: Florian Westphal <[email-masked]>
Date: Tue, 13 Aug 2024 20:58:33 +0200

Xin Long <[email-masked]> wrote:
> Similar to commit 70f06c115bcc ("sched: act_ct: switch to per-action
> label counting"), we should also switch to per-action label counting
> in openvswitch conntrack, as Florian suggested.
> 
> The difference is that nf_connlabels_get() is called unconditionally
> when creating an ct action in ovs_ct_copy_action(). As with these
> flows:
> 
>   table=0,ip,actions=ct(commit,table=1)
>   table=1,ip,actions=ct(commit,exec(set_field:0xac->ct_label),table=2)
> 
> it needs to make sure the label ext is created in the 1st flow before
> the ct is committed in ovs_ct_commit(). Otherwise, the warning in
> nf_ct_ext_add() when creating the label ext in the 2nd flow will
> be triggered:

With this and https://patchwork.ozlabs.org/project/netfilter-devel/patch/73[email-masked]/
applied new netns doesn't have conntrack enabled anymore, so

Acked-by: Florian Westphal <[email-masked]>

Thanks Xinlong!