From: kunwu.chan@linux•dev
To: trondmy@kernel•org, anna@kernel•org, chuck.lever@oracle•com,
jlayton@kernel•org, neilb@suse•de, kolga@netapp•com,
Dai.Ngo@oracle•com, tom@talpey•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com
Cc: linux-nfs@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, Kunwu Chan <chentao@kylinos•cn>
Subject: [PATCH] SUNRPC: Fix -Wformat-truncation warning
Date: Wed, 14 Aug 2024 17:38:53 +0800 [thread overview]
Message-ID: <20240814093853.48657-1-kunwu.chan@linux.dev> (raw)
From: Kunwu Chan <chentao@kylinos•cn>
Increase size of the servername array to avoid truncated output warning.
net/sunrpc/clnt.c:582:75: error：‘%s’ directive output may be truncated
writing up to 107 bytes into a region of size 48
[-Werror=format-truncation=]
582 | snprintf(servername, sizeof(servername), "%s",
| ^~
net/sunrpc/clnt.c:582:33: note:‘snprintf’ output
between 1 and 108 bytes into a destination of size 48
582 | snprintf(servername, sizeof(servername), "%s",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
583 | sun->sun_path);
Signed-off-by: Kunwu Chan <chentao@kylinos•cn>
---
net/sunrpc/clnt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 09f29a95f2bc..874085f3ed50 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -546,7 +546,7 @@ struct rpc_clnt *rpc_create(struct rpc_create_args *args)
.connect_timeout = args->connect_timeout,
.reconnect_timeout = args->reconnect_timeout,
};
- char servername[48];
+ char servername[108];
struct rpc_clnt *clnt;
int i;
--
2.40.1
next reply other threads:[~2024-08-14 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 9:38 kunwu.chan [this message]
2024-08-14 10:28 ` [PATCH] SUNRPC: Fix -Wformat-truncation warning NeilBrown
2024-08-15 8:30 ` Kunwu Chan
2024-08-15 11:39 ` NeilBrown
2024-08-16 1:52 ` Kunwu Chan
2024-08-16 22:01 ` Andrew Lunn
2024-08-16 23:07 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814093853.48657-1-kunwu.chan@linux.dev \
--to=kunwu.chan@linux$(echo .)dev \
--cc=Dai.Ngo@oracle$(echo .)com \
--cc=anna@kernel$(echo .)org \
--cc=chentao@kylinos$(echo .)cn \
--cc=chuck.lever@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jlayton@kernel$(echo .)org \
--cc=kolga@netapp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tom@talpey$(echo .)com \
--cc=trondmy@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox