From: Simon Horman <horms@kernel•org>
To: MD Danish Anwar <danishanwar@ti•com>
Cc: Suman Anna <s-anna@ti•com>, Sai Krishna <saikrishnag@marvell•com>,
Jan Kiszka <jan.kiszka@siemens•com>,
Dan Carpenter <dan.carpenter@linaro•org>,
Andrew Lunn <andrew@lunn•ch>, Diogo Ivo <diogo.ivo@siemens•com>,
Kory Maincent <kory.maincent@bootlin•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Paolo Abeni <pabeni@redhat•com>, Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
"David S. Miller" <davem@davemloft•net>,
Roger Quadros <rogerq@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Rob Herring <robh@kernel•org>,
Santosh Shilimkar <ssantosh@kernel•org>,
Nishanth Menon <nm@ti•com>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, srk@ti•com,
Vignesh Raghavendra <vigneshr@ti•com>
Subject: Re: [PATCH net-next v5 2/2] net: ti: icssg-prueth: Add support for PA Stats
Date: Thu, 15 Aug 2024 17:01:09 +0100 [thread overview]
Message-ID: <20240815160109.GN632411@kernel.org> (raw)
In-Reply-To: <20240814092033.2984734-3-danishanwar@ti.com>
On Wed, Aug 14, 2024 at 02:50:33PM +0530, MD Danish Anwar wrote:
...
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> index f678d656a3ed..ac2291d22c42 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> @@ -50,8 +50,10 @@
>
> #define ICSSG_MAX_RFLOWS 8 /* per slice */
>
> +#define ICSSG_NUM_PA_STATS 4
> +#define ICSSG_NUM_MII_G_RT_STATS 60
> /* Number of ICSSG related stats */
> -#define ICSSG_NUM_STATS 60
> +#define ICSSG_NUM_STATS (ICSSG_NUM_MII_G_RT_STATS + ICSSG_NUM_PA_STATS)
> #define ICSSG_NUM_STANDARD_STATS 31
> #define ICSSG_NUM_ETHTOOL_STATS (ICSSG_NUM_STATS - ICSSG_NUM_STANDARD_STATS)
>
> @@ -263,6 +265,7 @@ struct prueth {
> struct net_device *registered_netdevs[PRUETH_NUM_MACS];
> struct regmap *miig_rt;
> struct regmap *mii_rt;
> + struct regmap *pa_stats;
Please add an entry for pa_stats to the Kernel doc for this structure.
>
> enum pruss_pru_id pru_id[PRUSS_NUM_PRUS];
> struct platform_device *pdev;
...
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_stats.h b/drivers/net/ethernet/ti/icssg/icssg_stats.h
> index 999a4a91276c..e834316092c9 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_stats.h
> +++ b/drivers/net/ethernet/ti/icssg/icssg_stats.h
> @@ -77,6 +77,20 @@ struct miig_stats_regs {
> u32 tx_bytes;
> };
>
> +/**
> + * struct pa_stats_regs - ICSSG Firmware maintained PA Stats register
> + * @u32 fw_rx_cnt: Number of valid packets sent by Rx PRU to Host on PSI
> + * @u32 fw_tx_cnt: Number of valid packets copied by RTU0 to Tx queues
> + * @u32 fw_tx_pre_overflow: Host Egress Q (Pre-emptible) Overflow Counter
> + * @u32 fw_tx_exp_overflow: Host Egress Q (Express) Overflow Counter
> + */
./scripts/kernel-doc -none doesn't seem to like the syntax above.
Perhaps s/u32 // ?
> +struct pa_stats_regs {
> + u32 fw_rx_cnt;
> + u32 fw_tx_cnt;
> + u32 fw_tx_pre_overflow;
> + u32 fw_tx_exp_overflow;
> +};
> +
> #define ICSSG_STATS(field, stats_type) \
> { \
> #field, \
...
next prev parent reply other threads:[~2024-08-15 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 9:20 [PATCH net-next v5 0/2] Add support for ICSSG PA_STATS MD Danish Anwar
2024-08-14 9:20 ` [PATCH net-next v5 1/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support MD Danish Anwar
2024-08-14 9:20 ` [PATCH net-next v5 2/2] net: ti: icssg-prueth: Add support for PA Stats MD Danish Anwar
2024-08-15 11:28 ` Dan Carpenter
2024-08-19 7:15 ` Anwar, Md Danish
2024-08-15 16:01 ` Simon Horman [this message]
2024-08-19 7:10 ` Anwar, Md Danish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815160109.GN632411@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=diogo.ivo@siemens$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jan.kiszka@siemens$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm@ti$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=rogerq@kernel$(echo .)org \
--cc=s-anna@ti$(echo .)com \
--cc=saikrishnag@marvell$(echo .)com \
--cc=srk@ti$(echo .)com \
--cc=ssantosh@kernel$(echo .)org \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox