Subject: Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

From: Jakub Kicinski <[email-masked]>
Date: Thu, 15 Aug 2024 17:48:52 -0700

On Tue, 13 Aug 2024 21:13:05 +0000 Mina Almasry wrote:
> +int dev_get_max_mp_channel(const struct net_device *dev)
> +{
> +	int i, max = -1;

I presume the bug from yesterday is self evident once reported? :)

> +	ASSERT_RTNL();
> +
> +	for (i = 0; i < dev->real_num_rx_queues; i++)
> +		if (dev->_rx[i].mp_params.mp_priv)
> +			/* The number of queues is the idx plus 1. */
> +			max = i + 1;

The +1 is odd. The function as it stands reports min channel count.
Not max_mp_channel, if you ask me. And if you renamed it, you don't
have to use -1 as "not installed".

> +	return max;