Subject: Re: [PATCH net-next v1 1/3] ethtool: Extend cable testing interface with result source information

From: Jakub Kicinski <[email-masked]>
Date: Mon, 19 Aug 2024 17:26:08 -0700

On Mon, 19 Aug 2024 16:12:39 +0200 Oleksij Rempel wrote:
> --- a/include/uapi/linux/ethtool_netlink.h
> +++ b/include/uapi/linux/ethtool_netlink.h
> @@ -573,15 +573,25 @@ enum {
>  	ETHTOOL_A_CABLE_RESULT_UNSPEC,
>  	ETHTOOL_A_CABLE_RESULT_PAIR,		/* u8 ETHTOOL_A_CABLE_PAIR_ */
>  	ETHTOOL_A_CABLE_RESULT_CODE,		/* u8 ETHTOOL_A_CABLE_RESULT_CODE_ */
> +	ETHTOOL_A_CABLE_RESULT_SRC,		/* u32 */
>  
>  	__ETHTOOL_A_CABLE_RESULT_CNT,
>  	ETHTOOL_A_CABLE_RESULT_MAX = (__ETHTOOL_A_CABLE_RESULT_CNT - 1)
>  };
>  
> +/* Information source for specific results. */
> +enum {
> +	/* Results provided by the Time Domain Reflectometry (TDR) */
> +	ETHTOOL_A_CABLE_INF_SRC_TDR,
> +	/* Results provided by the Active Link Cable Diagnostic (ALCD) */
> +	ETHTOOL_A_CABLE_INF_SRC_ALCD,
> +};
> +
>  enum {
>  	ETHTOOL_A_CABLE_FAULT_LENGTH_UNSPEC,
>  	ETHTOOL_A_CABLE_FAULT_LENGTH_PAIR,	/* u8 ETHTOOL_A_CABLE_PAIR_ */
>  	ETHTOOL_A_CABLE_FAULT_LENGTH_CM,	/* u32 */
> +	ETHTOOL_A_CABLE_FAULT_LENGTH_SRC,	/* u32 */

Please keep Documentation/netlink/specs/ethtool.yaml up to date