Subject: Re: [PATCH net-next v2 2/9] bnxt_en: add support for retrieving crash dump using ethtool

From: Jakub Kicinski <[email-masked]>
Date: Mon, 19 Aug 2024 18:41:40 -0700

On Mon, 19 Aug 2024 12:12:39 +0200 Przemek Kitszel wrote:
> > +	if (dump_type == BNXT_DUMP_CRASH &&
> > +	    bp->fw_dbg_cap & DBG_QCAPS_RESP_FLAGS_CRASHDUMP_HOST_DDR &&  
> 
> I would wrap bitwise-and with parenthesis, even if not mandated by the C
> standard (the same in other places with combined expressions).

Personal preference, I guess. I generally lean on the side of limiting
the brackets.

👍️ to other comments, thank for reviewing!