Subject: Re: [PATCH -next 1/2] net/ipv4: fix macro definition sk_for_each_bound_bhash

From: Simon Horman <[email-masked]>
Date: Fri, 23 Aug 2024 17:27:11 +0100

On Fri, Aug 23, 2024 at 03:00:42PM +0800, Hongbo Li wrote:
> The macro sk_for_each_bound_bhash accepts a parameter
> __sk, but it was not used, rather the sk2 is directly
> used, so we replace the sk2 with __sk in macro.

Thanks.

I checked and there is only one user of this macro,
a little further down in the same file in inet_csk_bind_conflict().
It's usage matches the change you have made - it passes sk2 as __sk.

Reviewed-by: Simon Horman <[email-masked]>