Subject: Re: [PATCH net-next v2] net: dsa: vsc73xx: implement FDB operations

From: Simon Horman <[email-masked]>
Date: Sat, 24 Aug 2024 15:02:21 +0100

On Thu, Aug 22, 2024 at 04:23:44PM +0200, Pawel Dembicki wrote:
> This commit introduces implementations of three functions:
> .port_fdb_dump
> .port_fdb_add
> .port_fdb_del
> 
> The FDB database organization is the same as in other old Vitesse chips:
> It has 2048 rows and 4 columns (buckets). The row index is calculated by
> the hash function 'vsc73xx_calc_hash' and the FDB entry must be placed
> exactly into row[hash]. The chip selects the bucket number by itself.
> 
> Signed-off-by: Pawel Dembicki <[email-masked]>
> 
> ---
> Changes in v2:
>   - Use FIELD_PREP and macros in 'vsc73xx_calc_hash' funcion

Thanks for the update, that part now looks good to me.
I'll leave a proper review to others.

>   - improve commit message
>   - consolidate row, entry, bucket terminology
>   - check for error codes from vsc73xx_read() and vsc73xx_write()
>   - check if cr return error
>   - remove redundant comment
>   - set fdb_isolation flag

...