Subject: Re: [net-next v3 8/9] net: mvpp2: Convert to devm_clk_get_enabled() and devm_clk_get_optional_enabled()

From: Jonathan Cameron <[email-masked]>
Date: Tue, 27 Aug 2024 12:09:53 +0100

On Tue, 27 Aug 2024 03:57:11 -0600
Yangtao Li <[email-masked]> wrote:

> Use devm_clk_get_enabled() and devm_clk_get_optional_enabled()
> to simplify code.
> 
> Signed-off-by: Yangtao Li <[email-masked]>
> Reviewed-by: Maxime Chevallier <[email-masked]>
> Tested-by: Maxime Chevallier <[email-masked]>
> Suggested-by: Christophe JAILLET <[email-masked]>
> Reviewed-by: Marcin Wojtas <[email-masked]>

>  
> @@ -7745,12 +7710,6 @@ static void mvpp2_remove(struct platform_device *pdev)
>  
>  	if (!dev_of_node(&pdev->dev))
>  		return;

Given this makes no difference any more, drop the above dev_of_node() check.

> -
> -	clk_disable_unprepare(priv->axi_clk);
> -	clk_disable_unprepare(priv->mg_core_clk);
> -	clk_disable_unprepare(priv->mg_clk);
> -	clk_disable_unprepare(priv->pp_clk);
> -	clk_disable_unprepare(priv->gop_clk);
>  }
>  
>  static const struct of_device_id mvpp2_match[] = {