From: Jonathan Cameron <Jonathan.Cameron@Huawei•com>
To: Jinjie Ruan <ruanjinjie@huawei•com>
Cc: <woojung.huh@microchip•com>, <andrew@lunn•ch>,
<f.fainelli@gmail•com>, <olteanv@gmail•com>,
<davem@davemloft•net>, <edumazet@google•com>, <kuba@kernel•org>,
<pabeni@redhat•com>, <linus.walleij@linaro•org>,
<alsi@bang-olufsen•dk>, <justin.chen@broadcom•com>,
<sebastian.hesselbarth@gmail•com>, <alexandre.torgue@foss•st.com>,
<joabreu@synopsys•com>, <mcoquelin.stm32@gmail•com>,
<wens@csie•org>, <jernej.skrabec@gmail•com>,
<samuel@sholland•org>, <hkallweit1@gmail•com>,
<linux@armlinux•org.uk>, <ansuelsmth@gmail•com>,
<UNGLinuxDriver@microchip•com>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
<bcm-kernel-feedback-list@broadcom•com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-sunxi@lists•linux.dev>,
<linux-stm32@st-md-mailman•stormreply.com>, <krzk@kernel•org>,
<jic23@kernel•org>
Subject: Re: [PATCH net-next v2 07/13] net: mdio: mux-mmioreg: Simplified with scoped function
Date: Wed, 28 Aug 2024 13:46:05 +0100 [thread overview]
Message-ID: <20240828134605.00000d23@Huawei.com> (raw)
In-Reply-To: <20240828032343.1218749-8-ruanjinjie@huawei.com>
On Wed, 28 Aug 2024 11:23:37 +0800
Jinjie Ruan <ruanjinjie@huawei•com> wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop by using for_each_available_child_of_node_scoped().
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei•com>
Looks fine, though maybe driver would also benefit from dev_err_probe()
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei•com>
next prev parent reply other threads:[~2024-08-28 12:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:23 [PATCH net-next v2 00/13] net: Simplified with scoped function Jinjie Ruan
2024-08-28 3:23 ` [PATCH net-next v2 01/13] net: stmmac: dwmac-sun8i: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-28 12:38 ` Jonathan Cameron
2024-08-28 14:17 ` Andrew Lunn
2024-08-29 2:29 ` Jinjie Ruan
2024-08-28 3:23 ` [PATCH net-next v2 02/13] net: stmmac: dwmac-sun8i: Use __free() to simplify code Jinjie Ruan
2024-08-28 12:38 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 03/13] net: dsa: realtek: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-28 12:39 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 04/13] net: dsa: realtek: Use __free() to simplify code Jinjie Ruan
2024-08-28 12:37 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 05/13] net: phy: Fix missing of_node_put() for leds Jinjie Ruan
2024-08-28 12:40 ` Jonathan Cameron
2024-08-28 15:45 ` Willem de Bruijn
2024-08-29 2:46 ` Jinjie Ruan
2024-08-29 2:52 ` Jinjie Ruan
2024-08-28 3:23 ` [PATCH net-next v2 06/13] net: phy: Use for_each_available_child_of_node_scoped() Jinjie Ruan
2024-08-28 12:44 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 07/13] net: mdio: mux-mmioreg: Simplified with scoped function Jinjie Ruan
2024-08-28 12:46 ` Jonathan Cameron [this message]
2024-08-28 3:23 ` [PATCH net-next v2 08/13] net: mdio: mux-mmioreg: Simplified with dev_err_probe() Jinjie Ruan
2024-08-28 12:48 ` Jonathan Cameron
2024-08-29 3:11 ` Jinjie Ruan
2024-08-29 12:38 ` Andrew Lunn
2024-08-28 3:23 ` [PATCH net-next v2 09/13] net: mv643xx_eth: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-28 12:49 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 10/13] net: dsa: microchip: Use scoped function to simplfy code Jinjie Ruan
2024-08-28 12:50 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 11/13] net: dsa: microchip: Use __free() " Jinjie Ruan
2024-08-28 12:50 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 12/13] net: bcmasp: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-28 12:51 ` Jonathan Cameron
2024-08-28 3:23 ` [PATCH net-next v2 13/13] net: bcmasp: Simplify with __free() Jinjie Ruan
2024-08-28 12:53 ` Jonathan Cameron
2024-08-28 14:32 ` [PATCH net-next v2 00/13] net: Simplified with scoped function Andrew Lunn
2024-08-28 14:45 ` Krzysztof Kozlowski
2024-08-28 15:24 ` Andrew Lunn
2024-08-28 18:10 ` Jakub Kicinski
2024-08-29 3:26 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828134605.00000d23@Huawei.com \
--to=jonathan.cameron@huawei$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alsi@bang-olufsen$(echo .)dk \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=joabreu@synopsys$(echo .)com \
--cc=justin.chen@broadcom$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=wens@csie$(echo .)org \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox