From: Simon Horman <horms@kernel•org>
To: Jacobe Zang <jacobe.zang@wesion•com>
Cc: arend.vanspriel@broadcom•com, kvalo@kernel•org, marcan@marcan•st,
sven@svenpeter•dev, alyssa@rosenzweig•io, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
robh@kernel•org, krzk+dt@kernel•org, conor+dt@kernel•org,
saikrishnag@marvell•com, megi@xff•cz, bhelgaas@google•com,
duoming@zju•edu.cn, minipli@grsecurity•net, yajun.deng@linux•dev,
stern@rowland•harvard.edu, gregkh@linuxfoundation•org,
christophe.jaillet@wanadoo•fr, linux-wireless@vger•kernel.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
brcm80211@lists•linux.dev, brcm80211-dev-list.pdl@broadcom•com,
nick@khadas•com
Subject: Re: [PATCH v12 4/5] wifi: brcmfmac: Add optional lpo clock enable support
Date: Wed, 28 Aug 2024 15:53:48 +0100 [thread overview]
Message-ID: <20240828145348.GO1368797@kernel.org> (raw)
In-Reply-To: <20240828034915.969383-5-jacobe.zang@wesion.com>
On Wed, Aug 28, 2024 at 11:49:14AM +0800, Jacobe Zang wrote:
> WiFi modules often require 32kHz clock to function. Add support to
> enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
> to the top of brcmf_of_probe. Change function prototypes from void
> to int and add appropriate errno's for return values that will be
> send to bus when error occurred.
>
> Co-developed-by: Ondrej Jirman <megi@xff•cz>
> Signed-off-by: Ondrej Jirman <megi@xff•cz>
> Co-developed-by: Arend van Spriel <arend.vanspriel@broadcom•com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom•com>
> Reviewed-by: Sai Krishna <saikrishnag@marvell•com>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion•com>
...
> @@ -4452,7 +4454,9 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
> /* Allocate private bus interface state */
> bus = kzalloc(sizeof(*bus), GFP_ATOMIC);
> if (!bus)
> + ret = -ENOMEM;
> goto fail;
> + }
>
Perhaps a local change didn't make it into git, or something like that.
But this does not compile.
> bus->sdiodev = sdiodev;
> sdiodev->bus = bus;
...
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-28 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:49 [PATCH v12 0/5] Add AP6275P wireless support Jacobe Zang
2024-08-28 3:49 ` [PATCH v12 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Jacobe Zang
2024-08-28 3:49 ` [PATCH v12 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Jacobe Zang
2024-08-28 3:49 ` [PATCH v12 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure Jacobe Zang
2024-08-28 5:39 ` Krzysztof Kozlowski
2024-08-28 3:49 ` [PATCH v12 4/5] wifi: brcmfmac: Add optional lpo clock enable support Jacobe Zang
2024-08-28 14:53 ` Simon Horman [this message]
2024-08-28 3:49 ` [PATCH v12 5/5] wifi: brcmfmac: add flag for random seed during firmware download Jacobe Zang
-- strict thread matches above, loose matches on Subject: below --
2024-08-28 7:40 [PATCH v12 0/5] Add AP6276P wireless support Jacobe Zang
2024-08-28 7:40 ` [PATCH v12 4/5] wifi: brcmfmac: Add optional lpo clock enable support Jacobe Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828145348.GO1368797@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alyssa@rosenzweig$(echo .)io \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=brcm80211@lists$(echo .)linux.dev \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=duoming@zju$(echo .)edu.cn \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jacobe.zang@wesion$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=marcan@marcan$(echo .)st \
--cc=megi@xff$(echo .)cz \
--cc=minipli@grsecurity$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nick@khadas$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=saikrishnag@marvell$(echo .)com \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=sven@svenpeter$(echo .)dev \
--cc=yajun.deng@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox