Subject: Re: [PATCH v13 4/5] wifi: brcmfmac: Add optional lpo clock enable support

From: Simon Horman <[email-masked]>
Date: Wed, 28 Aug 2024 16:20:19 +0100

On Wed, Aug 28, 2024 at 04:49:25PM +0800, Jacobe Zang wrote:
> WiFi modules often require 32kHz clock to function. Add support to
> enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
> to the top of brcmf_of_probe. Change function prototypes from void
> to int and add appropriate errno's for return values that will be
> send to bus when error occurred.
> 
> Co-developed-by: Ondrej Jirman <[email-masked]>
> Signed-off-by: Ondrej Jirman <[email-masked]>
> Co-developed-by: Arend van Spriel <[email-masked]>
> Signed-off-by: Arend van Spriel <[email-masked]>
> Reviewed-by: Sai Krishna <[email-masked]>
> Signed-off-by: Jacobe Zang <[email-masked]>

...

> @@ -4452,7 +4454,9 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
>  	/* Allocate private bus interface state */
>  	bus = kzalloc(sizeof(*bus), GFP_ATOMIC);
>  	if (!bus)
> +		ret = -ENOMEM;
>  		goto fail;
> +	}
>  

Perhaps a local change didn't make it into git, or something like that.
But this does not compile. As was also the case in v12.
Please take time to test your patches, not just the local tree.

>  	bus->sdiodev = sdiodev;
>  	sdiodev->bus = bus;

-- 
pw-bot: cr